Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(413)

Issue 29764555: Noissue - Use two sets for excluded and included filters by domain (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by Manish Jethani
Modified:
1 year, 7 months ago
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

This builds on https://codereview.adblockplus.org/29757591/

Patch Set 1 #

Total comments: 5

Patch Set 2 : Rebase and minor changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -19 lines) Patch
M lib/elemHide.js View 1 4 chunks +37 lines, -19 lines 0 comments Download

Messages

Total messages: 7
Manish Jethani
1 year, 7 months ago (2018-04-28 16:16:06 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29764555/diff/29764556/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29764555/diff/29764556/lib/elemHide.js#newcode93 lib/elemHide.js:93: let setIndex = +isIncluded; Conveniently boolean ...
1 year, 7 months ago (2018-04-28 16:35:35 UTC) #2
Manish Jethani
https://codereview.adblockplus.org/29764555/diff/29764556/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29764555/diff/29764556/lib/elemHide.js#newcode271 lib/elemHide.js:271: for (let set of seenFilters) By the way, in ...
1 year, 7 months ago (2018-04-28 18:47:07 UTC) #3
kzar
This is certainly an interesting idea, but I'd like to see some numbers. I wonder: ...
1 year, 7 months ago (2018-05-02 12:41:49 UTC) #4
Manish Jethani
On 2018/05/02 12:41:49, kzar wrote: > This is certainly an interesting idea, but I'd like ...
1 year, 7 months ago (2018-05-02 21:06:53 UTC) #5
kzar
On 2018/05/02 12:41:49, kzar wrote: > 3. How often getSelectorsForDomain returns a different result from ...
1 year, 7 months ago (2018-05-04 13:58:56 UTC) #6
Manish Jethani
1 year, 7 months ago (2018-05-11 10:41:54 UTC) #7
I'm closing this because it only improves things by ~5-10% whereas as we have
much bigger improvements to make [1]. I might revisit this once all the other
changes have landed.

[1]: https://codereview.adblockplus.org/29773570/
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5