Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: pages/android.tmpl

Issue 29766571: Fixes #55 - Updated install button on Samsung Browser for Android (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Addressed #5 Created May 1, 2018, 11:23 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | static/js/vendor/bowser.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pages/android.tmpl
===================================================================
rename from pages/android.md
rename to pages/android.tmpl
--- a/pages/android.md
+++ b/pages/android.tmpl
@@ -1,1 +1,48 @@
+<head>
+ <style>
+ /* Hide TOS & Install on android page when not using Samsung Browser */
+ .android:not(.ua-samsung) #terms-message,
+ .android:not(.ua-samsung) #install,
+ /* Hide other platforms on android page when using Android */
+ .ua-andriod.android #other-platform,
+ /* Hide ABB banner on android page when using Samsung Browser */
+ #content.ua-android.ua-samsung #abb-banner
+ {
+ display: none;
+ }
+ </style>
+ <script src="/js/vendor/bowser.js"></script>
+ <script>
+ document.addEventListener("DOMContentLoaded", function()
+ {
+ if (!bowser instanceof Object) return;
+
+ var locale = "{{ locale }}";
+
+ var contentElement = document.getElementById("content");
+
+ // Replicating server behaviour on the frontend for testing
+ if (bowser.android)
+ contentElement.classList.add("ua-android");
+
+ if (bowser.samsungBrowser)
+ {
+ // Assign more specific user agent (ua-android is already present)
+ contentElement.classList.add("ua-samsung");
+
+ // change the Android install link to Samsung Browser
+ document
+ .getElementById("install-android")
+ .href = "https://play.google.com/store/apps/details?id=org.adblockplus.adblockplussbrowser";
+
+ // update the install button text in English *only*
+ if (locale == "en")
+ document
+ .getElementById("install-android")
+ .textContent = "Agree and Install for Samsung Internet";
+ }
+ });
+ </script>
+</head>
+
<? include index ?>
« no previous file with comments | « no previous file | static/js/vendor/bowser.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld