Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(718)

Issue 29767583: Issue 6626 - Document the rewrite filter option (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months, 2 weeks ago by hub
Modified:
1 month, 1 week ago
CC:
kzar
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

Issue 6626 - Document the rewrite filter option

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update from gdoc #

Total comments: 3

Patch Set 3 : Fixes #

Total comments: 2

Patch Set 4 : Addressed Julian's comments. Added a note about the restriction on content for rewriting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pages/filter-cheatsheet.html View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M pages/filters.html View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14
hub
2 months, 2 weeks ago (2018-05-01 19:56:20 UTC) #1
hub
The feature hasn't landed yet, and still subject to change. Stashing this in for now
2 months, 2 weeks ago (2018-05-01 19:57:48 UTC) #2
marielahuala61
2 months, 2 weeks ago (2018-05-05 08:29:38 UTC) #3
Sebastian Noack
Also note that we need a development build announcement. https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: ...
2 months, 2 weeks ago (2018-05-05 14:48:37 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: {{rewriteoption Rewrite the URL with the option <code><fix>rewrite=</fix></code>. You ...
2 months, 1 week ago (2018-05-08 06:32:23 UTC) #5
hub
Patch updated from gdoc https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: {{rewriteoption Rewrite the URL with ...
2 months, 1 week ago (2018-05-08 13:36:11 UTC) #6
Sebastian Noack
LGTM (for the content), but again Manish should have a look as well in case ...
2 months, 1 week ago (2018-05-08 17:06:05 UTC) #7
Manish Jethani
Also some comments in the Google Doc. https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify ...
2 months, 1 week ago (2018-05-10 02:47:40 UTC) #8
hub
https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify a rewrite rule for the URL to ...
2 months ago (2018-05-15 17:47:50 UTC) #9
juliandoucette
Thanks hub (and sorry about the delay if you were waiting for me). Only one ...
1 month, 4 weeks ago (2018-05-22 13:30:42 UTC) #10
hub
updated patch. https://codereview.adblockplus.org/29767583/diff/29782627/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29782627/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify a rewrite rule for the ...
1 month, 3 weeks ago (2018-05-29 19:05:47 UTC) #11
juliandoucette
LGTM
1 month, 2 weeks ago (2018-05-30 11:36:04 UTC) #12
Manish Jethani
Hubert, can we close this issue now?
1 month, 1 week ago (2018-06-08 12:19:25 UTC) #13
Sebastian Noack
1 month, 1 week ago (2018-06-08 15:13:10 UTC) #14
We will push these changes when we release Adblock Plus 3.2.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5