Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(34)

Issue 29767583: Issue 6626 - Document the rewrite filter option

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 weeks, 5 days ago by hub
Modified:
5 days, 13 hours ago
CC:
kzar
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

Issue 6626 - Document the rewrite filter option

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update from gdoc #

Total comments: 3

Patch Set 3 : Fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pages/filter-cheatsheet.html View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M pages/filters.html View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9
hub
2 weeks, 5 days ago (2018-05-01 19:56:20 UTC) #1
hub
The feature hasn't landed yet, and still subject to change. Stashing this in for now
2 weeks, 5 days ago (2018-05-01 19:57:48 UTC) #2
marielahuala61
2 weeks, 1 day ago (2018-05-05 08:29:38 UTC) #3
Sebastian Noack
Also note that we need a development build announcement. https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: ...
2 weeks, 1 day ago (2018-05-05 14:48:37 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: {{rewriteoption Rewrite the URL with the option <code><fix>rewrite=</fix></code>. You ...
1 week, 6 days ago (2018-05-08 06:32:23 UTC) #5
hub
Patch updated from gdoc https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: {{rewriteoption Rewrite the URL with ...
1 week, 5 days ago (2018-05-08 13:36:11 UTC) #6
Sebastian Noack
LGTM (for the content), but again Manish should have a look as well in case ...
1 week, 5 days ago (2018-05-08 17:06:05 UTC) #7
Manish Jethani
Also some comments in the Google Doc. https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify ...
1 week, 4 days ago (2018-05-10 02:47:40 UTC) #8
hub
5 days, 13 hours ago (2018-05-15 17:47:50 UTC) #9
https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheats...
File pages/filter-cheatsheet.html (right):

https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheats...
pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify a rewrite rule for
the URL to be performed before downloading. The filter should be a regular
expression. Use <code>$n</code> to insert submatches into the rewritten URL. See
JavaScript own <code>String.prototype.replace()</code>.}}</td>
On 2018/05/10 02:47:39, Manish Jethani wrote:
> The filter can very well be a string. e.g. /foo^$rewrite=/bar
> 
> I think we should write this as "If the filter is a regular expression, use $n
> to insert submatches ....".

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5