Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29767583: Issue 6626 - Document the rewrite filter option (Closed)

Created:
May 1, 2018, 7:56 p.m. by hub
Modified:
June 12, 2018, 12:44 p.m.
CC:
kzar
Base URL:
https://hg.adblockplus.org/web.adblockplus.org/
Visibility:
Public.

Description

Issue 6626 - Document the rewrite filter option

Patch Set 1 #

Total comments: 3

Patch Set 2 : Update from gdoc #

Total comments: 3

Patch Set 3 : Fixes #

Total comments: 2

Patch Set 4 : Addressed Julian's comments. Added a note about the restriction on content for rewriting. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M pages/filter-cheatsheet.html View 1 2 3 1 chunk +7 lines, -0 lines 0 comments Download
M pages/filters.html View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14
hub
May 1, 2018, 7:56 p.m. (2018-05-01 19:56:20 UTC) #1
hub
The feature hasn't landed yet, and still subject to change. Stashing this in for now
May 1, 2018, 7:57 p.m. (2018-05-01 19:57:48 UTC) #2
marielahuala61
May 5, 2018, 8:29 a.m. (2018-05-05 08:29:38 UTC) #3
Sebastian Noack
Also note that we need a development build announcement. https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: ...
May 5, 2018, 2:48 p.m. (2018-05-05 14:48:37 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: {{rewriteoption Rewrite the URL with the option <code><fix>rewrite=</fix></code>. You ...
May 8, 2018, 6:32 a.m. (2018-05-08 06:32:23 UTC) #5
hub
Patch updated from gdoc https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html File pages/filters.html (right): https://codereview.adblockplus.org/29767583/diff/29767584/pages/filters.html#newcode185 pages/filters.html:185: {{rewriteoption Rewrite the URL with ...
May 8, 2018, 1:36 p.m. (2018-05-08 13:36:11 UTC) #6
Sebastian Noack
LGTM (for the content), but again Manish should have a look as well in case ...
May 8, 2018, 5:06 p.m. (2018-05-08 17:06:05 UTC) #7
Manish Jethani
Also some comments in the Google Doc. https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify ...
May 10, 2018, 2:47 a.m. (2018-05-10 02:47:40 UTC) #8
hub
https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29774555/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify a rewrite rule for the URL to ...
May 15, 2018, 5:47 p.m. (2018-05-15 17:47:50 UTC) #9
juliandoucette
Thanks hub (and sorry about the delay if you were waiting for me). Only one ...
May 22, 2018, 1:30 p.m. (2018-05-22 13:30:42 UTC) #10
hub
updated patch. https://codereview.adblockplus.org/29767583/diff/29782627/pages/filter-cheatsheet.html File pages/filter-cheatsheet.html (right): https://codereview.adblockplus.org/29767583/diff/29782627/pages/filter-cheatsheet.html#newcode629 pages/filter-cheatsheet.html:629: <td>{{rewritedesc Specify a rewrite rule for the ...
May 29, 2018, 7:05 p.m. (2018-05-29 19:05:47 UTC) #11
juliandoucette
LGTM
May 30, 2018, 11:36 a.m. (2018-05-30 11:36:04 UTC) #12
Manish Jethani
Hubert, can we close this issue now?
June 8, 2018, 12:19 p.m. (2018-06-08 12:19:25 UTC) #13
Sebastian Noack
June 8, 2018, 3:13 p.m. (2018-06-08 15:13:10 UTC) #14
We will push these changes when we release Adblock Plus 3.2.

Powered by Google App Engine
This is Rietveld