Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29768621: #10639 - node-sass output filter (Closed)

Created:
May 2, 2018, 12:48 p.m. by l.rosilio
Modified:
July 2, 2018, 2:21 p.m.
Reviewers:
f.lopez, mathias, Fred
Visibility:
Public.

Description

#10639 - node-sass output filter

Patch Set 1 #

Patch Set 2 : #10639 - node-sass output filter #

Patch Set 3 : #10639 - node-sass output filter #

Total comments: 1

Patch Set 4 : #10639 - node-sass output filter #

Total comments: 2

Patch Set 5 : #10639 - node-sass output filter #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -0 lines) Patch
A edit.sh View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 8
l.rosilio
May 2, 2018, 12:48 p.m. (2018-05-02 12:48:41 UTC) #1
l.rosilio
May 14, 2018, 2:57 p.m. (2018-05-14 14:57:53 UTC) #2
l.rosilio
June 11, 2018, 10:36 a.m. (2018-06-11 10:36:11 UTC) #3
mathias
https://codereview.adblockplus.org/29768621/diff/29804566/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29768621/diff/29804566/edit.sh#newcode7 edit.sh:7: *Rendering*|*Wrote*) Can't you make these patterns more specific, in ...
June 11, 2018, 2:04 p.m. (2018-06-11 14:04:14 UTC) #4
l.rosilio
June 12, 2018, 2:56 p.m. (2018-06-12 14:56:04 UTC) #5
mathias
Almost there :) https://codereview.adblockplus.org/29768621/diff/29805567/edit.sh File edit.sh (right): https://codereview.adblockplus.org/29768621/diff/29805567/edit.sh#newcode7 edit.sh:7: *Rendering?Complete,?saving*file*|*Wrote?CSS?to?*) As discussed: Please remove the ...
June 19, 2018, 12:59 p.m. (2018-06-19 12:59:49 UTC) #6
l.rosilio
June 20, 2018, 12:34 p.m. (2018-06-20 12:34:29 UTC) #7
mathias
June 20, 2018, 12:53 p.m. (2018-06-20 12:53:14 UTC) #8
LGTM.

Powered by Google App Engine
This is Rietveld