Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29768682: Noissue - Update JSDoc @type for Matcher.filterByKeyword (Closed)

Created:
May 2, 2018, 8:55 p.m. by Manish Jethani
Modified:
May 4, 2018, 2:50 p.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Update JSDoc @type for Matcher.filterByKeyword

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M lib/matcher.js View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
Manish Jethani
May 2, 2018, 8:56 p.m. (2018-05-02 20:56:02 UTC) #1
Manish Jethani
Patch Set 1 https://codereview.adblockplus.org/29768682/diff/29768683/lib/matcher.js File lib/matcher.js (right): https://codereview.adblockplus.org/29768682/diff/29768683/lib/matcher.js#newcode40 lib/matcher.js:40: * @type {Map.<string,(Filter|Filter[])>} This can be ...
May 2, 2018, 9:03 p.m. (2018-05-02 21:03:54 UTC) #2
kzar
May 4, 2018, 1:57 p.m. (2018-05-04 13:57:01 UTC) #3
Well spotted, LGTM

Powered by Google App Engine
This is Rietveld