Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29770601: Issue 6649 - Allow u flag in :-abp-contains() (Closed)

Created:
May 5, 2018, 1:46 a.m. by Manish Jethani
Modified:
May 8, 2018, 6:04 p.m.
Reviewers:
hub
CC:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 6649 - Allow u flag in :-abp-contains()

Patch Set 1 #

Patch Set 2 : Add tests #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M lib/content/elemHideEmulation.js View 1 chunk +1 line, -1 line 0 comments Download
M test/browser/elemHideEmulation.js View 1 2 chunks +15 lines, -1 line 1 comment Download

Messages

Total messages: 3
Manish Jethani
May 5, 2018, 1:46 a.m. (2018-05-05 01:46:08 UTC) #1
Manish Jethani
Patch Set 1 Patch Set 2: Add tests https://codereview.adblockplus.org/29770601/diff/29770604/test/browser/elemHideEmulation.js File test/browser/elemHideEmulation.js (right): https://codereview.adblockplus.org/29770601/diff/29770604/test/browser/elemHideEmulation.js#newcode572 test/browser/elemHideEmulation.js:572: test, ...
May 5, 2018, 2:01 a.m. (2018-05-05 02:01:49 UTC) #2
hub
May 8, 2018, 4:42 p.m. (2018-05-08 16:42:55 UTC) #3
I'm not sure about performance, but from an internationalization point of view,
this seems to be necessary.

LGTM

Powered by Google App Engine
This is Rietveld