Issue 6647 - Stop converting domains from punycode to unicode

lib/options.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 /** @module options */
 
 "use strict";
 
-const {getDecodedHostname} = require("./url");
 const {checkWhitelisted} = require("./whitelisting");
 const info = require("../buildtools/info");
 
 const optionsUrl = "options.html";
 
 function findOptionsTab(callback)
 {
   browser.tabs.query({}, tabs =>
   {
     // We find a tab ourselves because Edge has a bug when quering tabs with
@@ skipping 174 matching lines @@
     showOptions((optionsPage, port) =>
     {
       if (!/^https?:$/.test(currentPage.url.protocol))
         return;
 
       port.postMessage({
         type: "app.respond",
         action: "showPageOptions",
         args: [
           {
-            host: getDecodedHostname(currentPage.url).replace(/^www\./, ""),
+            host: currentPage.url.hostname.replace(/^www\./, ""),

[Manish Jethani, 2018/05/06 18:37:13]

Should we also display the encoded hostname in the UI? Maybe this is a case
where it would still be a good idea to display the Unicode version of the name.

[Sebastian Noack, 2018/05/06 18:47:40]

Whatever we do here, it will be inconsistent with what the browser shows in the
address bar. Firefox and Chrome apply different heuristics to determine whether
to render the domain in the URL in the address bar as unicode (or to show the
raw punycode). Ideally, we would use the same representation as in the address
bar but that isn't possible. Also note that this is only for the mobile options
page in Firefox on Android. Also keep in mind that we would have to keep the
punycode library included in the repository and the builds just for this.

[Manish Jethani, 2018/05/07 17:03:45]

I remember when I was testing ABP on Firefox for Android it was neat to see the
domain i❤️.ws appear on the options page. I don't even remember if it's
displayed like that in the address bar. Anyway, I'm OK with this change.

             whitelisted: !!checkWhitelisted(currentPage)
           }
         ]
       });
     });
   });
 });