Issue 6652 - Implement fast selector lookups for unknown domains

lib/elemHide.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 100 matching lines @@
         continue;
 
       let filters = filtersByDomain.get(domain);
       if (!filters)
         filtersByDomain.set(domain, filters = new Map());
       filters.set(filter, isIncluded);
     }
   }
 }
 
-
-/**
- * Checks whether a filter applies on a domain
- * @param {Filter} filter
- * @param {string} [domain]
- * @param {Set.<Filter>} excludeSet
- * @returns {boolean}
- */
-function doesFilterApply(filter, domain, excludeSet)
-{
-  return (excludeSet.size == 0 || !excludeSet.has(filter)) &&
-         !exports.ElemHide.getException(filter, domain);
-}
-
 /**
  * Returns a list of domain-specific filters matching a domain
  * @param {string} [domain]
  * @returns {Array.<{domain: string, filters: ?Map.<Filter,boolean>}>}
  */
 function getSpecificFiltersForDomain(domain)
 {
   let filtersList = [];
 
   if (domain)
@@ skipping 27 matching lines @@
   // This code is a performance hot-spot, which is why we've made certain
   // micro-optimisations. Please be careful before making changes.
   for (let i = 0; i < filtersList.length; i++)
   {
     let {filters} = filtersList[i];
     if (filters)
     {
       for (let [filter, isIncluded] of filters)
       {
         if (!isIncluded)
+        {
           excludeSet.add(filter);
-        else if (doesFilterApply(filter, domain, excludeSet))
+        }
+        else if ((excludeSet.size == 0 || !excludeSet.has(filter)) &&
+                  !exports.ElemHide.getException(filter, domain))
+        {
           matches.push(filter.selector);
+        }
       }
     }
   }
 
   return matches;
 }
 
 /**
  * Returns a list of selectors that apply on a domain
  * @param {string} [domain]
@@ skipping 247 matching lines @@
   getSelectorsForDomain(domain, specificOnly = false)
   {
     let selectors = getConditionalSelectorsForDomain(domain, specificOnly);
 
     if (!specificOnly)
       selectors = getUnconditionalSelectors().concat(selectors);
 
     return selectors;
   }
 };