Issue 5761 - Changes require paths to relative

background.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 72 matching lines @@
   const subscriptionServer = "https://easylist-downloads.adblockplus.org";
   const easyListGermany = `${subscriptionServer}/easylistgermany+easylist.txt`;
   const acceptableAds = `${subscriptionServer}/exceptionrules.txt`;
   const acceptableAdsPrivacyFriendly =
     `${subscriptionServer}/exceptionrules-privacy-friendly.txt`;
   const redirectLink = "https://adblockplus.org/redirect?link=";
 
   let modules = {};
   window.require = function(module)
   {
-    return modules[module];
+    return modules[module.substr(module.lastIndexOf("/") + 1)];

[a.giammarchi, 2018/07/02 08:14:26]

this is probably already fine but assumes there is a `/` in the path.

What always works and produces same result instead is `module.split('/').pop()`,
so that even if there's no slash in the path, you'll have a module to load (i.e.
the "info" one, whenever it gets involved in here).

Feel free to ignore this comment if there won't ever be a case without a slash.

[Jon Sonesen, 2018/07/09 19:23:49]

Yeah, previously there were never `/` characters but now i think they will
always appear (perhaps the info module is the exception here) Thomas, Dave what
do you think?

[Thomas Greiner, 2018/07/26 10:07:59]

I'd say let's go with whichever requires making fewer assumptions. So in this
case that would be `module.split("/").pop()`.

   };
 
   modules.utils = {
     Utils: {
       getDocLink(link)
       {
         return `${redirectLink}${encodeURIComponent(link)}`;
       },
       get appLocale()
       {
@@ skipping 526 matching lines @@
       },
       filter: {
         text: "||example.com/some-annoying-popup$popup",
         whitelisted: false,
         userDefined: true,
         subscription: null
       }
     });
   });
 }());