Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29775605: Noissue - Update JSDoc to mark optionals in lib/elemHide.js (Closed)

Created:
May 9, 2018, 5:15 p.m. by Manish Jethani
Modified:
May 11, 2018, 3:24 a.m.
Reviewers:
kzar
CC:
sergei
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Update JSDoc to mark optionals in lib/elemHide.js

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -2 lines) Patch
M lib/elemHide.js View 3 chunks +11 lines, -2 lines 1 comment Download

Messages

Total messages: 4
Manish Jethani
May 9, 2018, 5:15 p.m. (2018-05-09 17:15:25 UTC) #1
Manish Jethani
Patch Set 1
May 9, 2018, 5:16 p.m. (2018-05-09 17:16:26 UTC) #2
Manish Jethani
https://codereview.adblockplus.org/29775605/diff/29775606/lib/elemHide.js File lib/elemHide.js (right): https://codereview.adblockplus.org/29775605/diff/29775606/lib/elemHide.js#newcode223 lib/elemHide.js:223: * @type {number} Unrelated but helpful.
May 9, 2018, 5:16 p.m. (2018-05-09 17:16:57 UTC) #3
kzar
May 10, 2018, 11:02 a.m. (2018-05-10 11:02:09 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld