Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(241)

Issue 29777646: Issue 6586 - Handle intiator of "null" on Chrome >=66 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by Sebastian Noack
Modified:
1 year, 3 months ago
Reviewers:
kzar
Visibility:
Public.

Description

Issue 6586 - Handle intiator of "null" on Chrome >=66

Patch Set 1 #

Total comments: 6
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M lib/requestBlocker.js View 3 chunks +10 lines, -6 lines 6 comments Download

Messages

Total messages: 6
Sebastian Noack
https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js#newcode186 lib/requestBlocker.js:186: // an "initiator", this implies a request sent by ...
1 year, 3 months ago (2018-05-10 15:41:40 UTC) #1
kzar
https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js#newcode115 lib/requestBlocker.js:115: else if (details.initiator && details.initiator != "null") Why are ...
1 year, 3 months ago (2018-05-11 12:50:17 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js#newcode115 lib/requestBlocker.js:115: else if (details.initiator && details.initiator != "null") On 2018/05/11 ...
1 year, 3 months ago (2018-05-11 12:52:40 UTC) #3
kzar
https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js#newcode115 lib/requestBlocker.js:115: else if (details.initiator && details.initiator != "null") On 2018/05/11 ...
1 year, 3 months ago (2018-05-11 12:58:56 UTC) #4
Sebastian Noack
https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js File lib/requestBlocker.js (right): https://codereview.adblockplus.org/29777646/diff/29777647/lib/requestBlocker.js#newcode115 lib/requestBlocker.js:115: else if (details.initiator && details.initiator != "null") On 2018/05/11 ...
1 year, 3 months ago (2018-05-11 13:04:44 UTC) #5
kzar
1 year, 3 months ago (2018-05-11 13:12:36 UTC) #6
Weird, well fair enough. LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5