Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(618)

Issue 29777652: #6145 - Introduce deploy script for websites (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 1 week ago by f.lopez
Modified:
2 months, 2 weeks ago
Visibility:
Public.

Description

#6145 - Introduce deploy script for websites

Patch Set 1 #

Total comments: 20

Patch Set 2 : For comment 2 #

Patch Set 3 : Forgot to remove unused import #

Total comments: 12

Patch Set 4 : For comment 7 #

Patch Set 5 : Forgot to add some changes #

Total comments: 12

Patch Set 6 : For comment 12 #

Total comments: 8

Patch Set 7 : For comment 15 #

Patch Set 8 : Use of a different name convention for the script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -0 lines) Patch
A modules/adblockplus/files/web/static/deploy_script.py View 1 2 3 4 5 6 7 1 chunk +133 lines, -0 lines 0 comments Download

Messages

Total messages: 19
f.lopez
4 months, 1 week ago (2018-05-10 23:21:09 UTC) #1
Vasily Kuznetsov
Hi Paco! In general the script looks good. See some of the comments to the ...
4 months, 1 week ago (2018-05-15 18:09:37 UTC) #2
f.lopez
Thanks for your review, I'll be sending a new patch shortly https://codereview.adblockplus.org/29777652/diff/29777653/modules/adblockplus/files/web/static/deploy_script.py File modules/adblockplus/files/web/static/deploy_script.py (right): ...
4 months ago (2018-05-21 22:23:42 UTC) #3
f.lopez
4 months ago (2018-05-22 01:31:56 UTC) #4
f.lopez
4 months ago (2018-05-22 01:34:30 UTC) #5
Vasily Kuznetsov
Hi Paco, Good progress. I didn't finish reviewing the new patch, but I will post ...
4 months ago (2018-05-22 16:38:37 UTC) #6
Vasily Kuznetsov
A few more comments after I had a second look. Now consider patch 3 reviewed ...
3 months, 4 weeks ago (2018-05-23 12:25:44 UTC) #7
f.lopez
Gonna send a patch shortly https://codereview.adblockplus.org/29777652/diff/29786557/modules/adblockplus/files/web/static/deploy_script.py File modules/adblockplus/files/web/static/deploy_script.py (right): https://codereview.adblockplus.org/29777652/diff/29786557/modules/adblockplus/files/web/static/deploy_script.py#newcode22 modules/adblockplus/files/web/static/deploy_script.py:22: filename, _ = urllib.urlretrieve(url, ...
3 months, 2 weeks ago (2018-06-06 00:05:03 UTC) #8
f.lopez
3 months, 2 weeks ago (2018-06-06 00:32:59 UTC) #9
f.lopez
3 months, 2 weeks ago (2018-06-06 00:35:33 UTC) #10
Vasily Kuznetsov
LGTM
3 months, 2 weeks ago (2018-06-06 17:21:19 UTC) #11
mathias
https://codereview.adblockplus.org/29777652/diff/29799626/modules/adblockplus/files/web/static/deploy_script.py File modules/adblockplus/files/web/static/deploy_script.py (right): https://codereview.adblockplus.org/29777652/diff/29799626/modules/adblockplus/files/web/static/deploy_script.py#newcode1 modules/adblockplus/files/web/static/deploy_script.py:1: #!/usr/bin/env python According to our legal department all source ...
3 months, 1 week ago (2018-06-07 21:52:00 UTC) #12
f.lopez
https://codereview.adblockplus.org/29777652/diff/29799626/modules/adblockplus/files/web/static/deploy_script.py File modules/adblockplus/files/web/static/deploy_script.py (right): https://codereview.adblockplus.org/29777652/diff/29799626/modules/adblockplus/files/web/static/deploy_script.py#newcode1 modules/adblockplus/files/web/static/deploy_script.py:1: #!/usr/bin/env python On 2018/06/07 21:52:00, mathias wrote: > According ...
3 months ago (2018-06-18 18:41:30 UTC) #13
f.lopez
3 months ago (2018-06-18 18:44:29 UTC) #14
mathias
Almost there :) https://codereview.adblockplus.org/29777652/diff/29809750/modules/adblockplus/files/web/static/deploy_script.py File modules/adblockplus/files/web/static/deploy_script.py (right): https://codereview.adblockplus.org/29777652/diff/29809750/modules/adblockplus/files/web/static/deploy_script.py#newcode29 modules/adblockplus/files/web/static/deploy_script.py:29: _doc = """This script MUST be ...
3 months ago (2018-06-18 19:58:39 UTC) #15
f.lopez
https://codereview.adblockplus.org/29777652/diff/29809750/modules/adblockplus/files/web/static/deploy_script.py File modules/adblockplus/files/web/static/deploy_script.py (right): https://codereview.adblockplus.org/29777652/diff/29809750/modules/adblockplus/files/web/static/deploy_script.py#newcode29 modules/adblockplus/files/web/static/deploy_script.py:29: _doc = """This script MUST be renamed in the ...
3 months ago (2018-06-18 22:47:43 UTC) #16
f.lopez
3 months ago (2018-06-18 22:48:47 UTC) #17
f.lopez
2 months, 2 weeks ago (2018-07-04 14:12:18 UTC) #18
mathias
2 months, 2 weeks ago (2018-07-04 14:53:11 UTC) #19
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5