Issue 29777679: Issue 6657 - Add whitelist translations

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29777679: Issue 6657 - Add whitelist translations (Closed)

Created:
May 11, 2018, 12:18 a.m. by diegocarloslima

Modified:
May 14, 2018, 9:45 p.m.

Reviewers:
anton, jens

Visibility:
Public.

Description

Issue 6657 - Add whitelist translations

Patch Set 1 #

Patch Set 2 : Adjusting one string in pt-BR as discussed with Tamara #

Created: May 14, 2018, 9:10 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+149 lines, -149 lines)			Patch
M	mobile/android/base/locales/adblockbrowser/cs/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/de/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/el/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/es-AR/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/es-ES/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/es-MX/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/fr/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/it/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/ja/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/ko/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/ms/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/nl/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/pl/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/pt-BR/android_strings.dtd	View	1	2 chunks	+8 lines, -8 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/pt-PT/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/ru/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/th/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/tr/android_strings.dtd	View		2 chunks	+8 lines, -8 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/vi/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/zh-CN/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	mobile/android/base/locales/adblockbrowser/zh-TW/android_strings.dtd	View		2 chunks	+7 lines, -7 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

anton

On 2018/05/11 00:20:42, diegocarloslima wrote: LGTM (though `abb_whitelist_website_dialog_hint` can be removed from all the lists ...

May 11, 2018, 9:40 a.m. (2018-05-11 09:40:40 UTC) #2

jens

May 11, 2018, 12:46 p.m. (2018-05-11 12:46:25 UTC) #3

On 2018/05/11 09:40:40, anton wrote:
> On 2018/05/11 00:20:42, diegocarloslima wrote:
> 
> LGTM (though `abb_whitelist_website_dialog_hint` can be removed from all the
> lists as it's not actually translated, assuming it's left for readability).

LGTM

Expand All Messages | Collapse All Messages