Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29778572: Noissue - Make private functions inaccessible via ElemHide object (Closed)

Created:
May 11, 2018, 12:14 p.m. by Manish Jethani
Modified:
May 11, 2018, 1:07 p.m.
Reviewers:
kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Make private functions inaccessible via ElemHide object

Patch Set 1 #

Patch Set 2 : Add JSDoc comment #

Patch Set 3 : Fix JSDoc comment error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -30 lines) Patch
M lib/elemHide.js View 1 2 5 chunks +35 lines, -30 lines 0 comments Download

Messages

Total messages: 5
Manish Jethani
May 11, 2018, 12:14 p.m. (2018-05-11 12:14:50 UTC) #1
Manish Jethani
Patch Set 1 Based on discussion in https://codereview.adblockplus.org/29774573/
May 11, 2018, 12:15 p.m. (2018-05-11 12:15:47 UTC) #2
Manish Jethani
Patch Set 2: Add JSDoc comment
May 11, 2018, 12:20 p.m. (2018-05-11 12:20:30 UTC) #3
Manish Jethani
Patch Set 3: Fix JSDoc comment error
May 11, 2018, 12:26 p.m. (2018-05-11 12:26:24 UTC) #4
kzar
May 11, 2018, 12:47 p.m. (2018-05-11 12:47:33 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld