Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29782593: Noissue - Don't hard-code options and popup URL (Closed)

Created:
May 15, 2018, 1:22 p.m. by Sebastian Noack
Modified:
May 15, 2018, 2:52 p.m.
Reviewers:
kzar
Visibility:
Public.

Description

Noissue - Don't hard-code options and popup URL

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add default_popup on Firefox #

Patch Set 3 : Use "" instead of null for compatiblity with older Firefox versions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -8 lines) Patch
M lib/options.js View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M metadata.gecko View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4
Sebastian Noack
For reference, the hard-coded popup URL currently prevent AdBlock from updating to the latest version ...
May 15, 2018, 1:23 p.m. (2018-05-15 13:23:21 UTC) #1
kzar
Might be a good idea to file an issue for this change so that Ross ...
May 15, 2018, 1:32 p.m. (2018-05-15 13:32:32 UTC) #2
Sebastian Noack
https://codereview.adblockplus.org/29782593/diff/29782594/lib/options.js File lib/options.js (right): https://codereview.adblockplus.org/29782593/diff/29782594/lib/options.js#newcode26 lib/options.js:26: const optionsUrl = manifest.options_page || manifest.options_ui.page; On 2018/05/15 13:32:31, ...
May 15, 2018, 2:17 p.m. (2018-05-15 14:17:16 UTC) #3
kzar
May 15, 2018, 2:37 p.m. (2018-05-15 14:37:50 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld