Issue 6596 - update to work with v8 6.7.288.11

include/AdblockPlus/JsEngine.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 21 matching lines @@
 #include <AdblockPlus/IWebRequest.h>
 #include <AdblockPlus/ITimer.h>
 #include <AdblockPlus/Scheduler.h>
 
 namespace v8
 {
   class Isolate;
   class Value;
   class Context;
   template<typename T> class FunctionCallbackInfo;
-  typedef void(*FunctionCallback)(const FunctionCallbackInfo<v8::Value>& info);
+  typedef void(*FunctionCallback)(const FunctionCallbackInfo<Value>& info);

[hub, 2018/05/23 18:27:05]

Nit: is this change *needed* here, or was just a drive by?

[sergei, 2018/05/24 08:45:42]

It is needed. I was also surprised, but otherwise there is a compilation error.

[hub, 2018/05/24 12:29:51]

Acknowledged.

 }
 
 namespace AdblockPlus
 {
   class JsEngine;
   class Platform;
 
   /**
    * Shared smart pointer to a `JsEngine` instance.
    */
@@ skipping 237 matching lines @@
 
     std::unique_ptr<v8::Global<v8::Context>> context;
     EventMap eventCallbacks;
     std::mutex eventCallbacksMutex;
     JsWeakValuesLists jsWeakValuesLists;
     std::mutex jsWeakValuesListsMutex;
   };
 }
 
 #endif