include/AdblockPlus/JsEngine.h - Issue 29783566: Issue 6596 - update to work with v8 6.7.288.11

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: include/AdblockPlus/JsEngine.h

Issue 29783566: Issue 6596 - update to work with v8 6.7.288.11 (Closed) Base URL: https://github.com/adblockplus/libadblockplus@99836840e314b7941fdb51cb2b91f23ca3ee3414

Patch Set: Created May 16, 2018, 10:17 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: include/AdblockPlus/JsEngine.h

diff --git a/include/AdblockPlus/JsEngine.h b/include/AdblockPlus/JsEngine.h

index 4309044e0aecb8c026a20f50aa2a70216b161341..833e0d3279f1533660426ca38070dd4f296cebe9 100644

--- a/include/AdblockPlus/JsEngine.h

+++ b/include/AdblockPlus/JsEngine.h

@@ -39,7 +39,7 @@ namespace v8

class Value;

class Context;

template<typename T> class FunctionCallbackInfo;

- typedef void(*FunctionCallback)(const FunctionCallbackInfo<v8::Value>& info);

+ typedef void(*FunctionCallback)(const FunctionCallbackInfo<Value>& info);

hub 2018/05/23 18:27:05 Nit: is this change *needed* here, or was just a d

sergei 2018/05/24 08:45:42 It is needed. I was also surprised, but otherwise

hub 2018/05/24 12:29:51 Acknowledged.

}

namespace AdblockPlus

« README.md ('K') | « dependencies ('k') | libadblockplus.gyp » ('j') | no next file with comments »