Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/elemHideEmulation.js

Issue 29783618: Issue 6665 - Split out element hiding exceptions into their own module (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Created May 17, 2018, 3:46 a.m.
Right Patch Set: Add lib/elemHideExceptions.js Created Aug. 7, 2018, 2:18 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « lib/elemHide.js ('k') | lib/elemHideExceptions.js » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 * @param {string} domain 62 * @param {string} domain
63 * @return {ElemHideEmulationFilter[]} 63 * @return {ElemHideEmulationFilter[]}
64 */ 64 */
65 getRulesForDomain(domain) 65 getRulesForDomain(domain)
66 { 66 {
67 let result = []; 67 let result = [];
68 for (let text of filters.values()) 68 for (let text of filters.values())
69 { 69 {
70 let filter = Filter.fromText(text); 70 let filter = Filter.fromText(text);
71 if (filter.isActiveOnDomain(domain) && 71 if (filter.isActiveOnDomain(domain) &&
72 !ElemHideExceptions.getException(filter, domain)) 72 !ElemHideExceptions.getException(filter.selector, domain))
73 { 73 {
74 result.push(filter); 74 result.push(filter);
75 } 75 }
76 } 76 }
77 return result; 77 return result;
78 } 78 }
79 }; 79 };
80 exports.ElemHideEmulation = ElemHideEmulation; 80 exports.ElemHideEmulation = ElemHideEmulation;
LEFTRIGHT

Powered by Google App Engine
This is Rietveld