Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: lib/elemHideEmulation.js

Issue 29784555: Issue 6665 - Abstract element hiding container logic into its own module Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Rebase Created May 17, 2018, 5:31 a.m.
Right Patch Set: Move base class into lib/contentFilterModule.js Created Aug. 15, 2018, 8:56 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the 11 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12 * GNU General Public License for more details. 12 * GNU General Public License for more details.
13 * 13 *
14 * You should have received a copy of the GNU General Public License 14 * You should have received a copy of the GNU General Public License
15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>. 15 * along with Adblock Plus. If not, see <http://www.gnu.org/licenses/>.
16 */ 16 */
17 17
18 "use strict"; 18 "use strict";
19 19
20 /** 20 /**
21 * @fileOverview Element hiding emulation implementation. 21 * @fileOverview Element hiding emulation implementation.
22 */ 22 */
23 23
24 const {ElemHideTemplate} = require("./elemHide"); 24 const {ContentFilterModule} = require("./contentFilterModule");
25 const {ElemHideExceptions} = require("./elemHideExceptions"); 25 const {ElemHideExceptions} = require("./elemHideExceptions");
26 26
27 /** 27 /**
28 * Container for element hiding emulation filters 28 * Container for element hiding emulation filters
29 * @class 29 * @class
30 */ 30 */
31 exports.ElemHideEmulation = Object.assign(new ElemHideTemplate(), { 31 exports.ElemHideEmulation = Object.assign(new ContentFilterModule(), {
Manish Jethani 2018/05/17 05:51:54 ElemHideEmulation is now just like ElemHide, but w
32 /** 32 /**
33 * Returns a list of all rules active on a particular domain 33 * Returns a list of all rules active on a particular domain
34 * @param {string} domain 34 * @param {string} domain
35 * @return {ElemHideEmulationFilter[]} 35 * @return {ElemHideEmulationFilter[]}
36 */ 36 */
37 getRulesForDomain(domain) 37 getRulesForDomain(domain)
38 { 38 {
39 let result = []; 39 let result = [];
40 for (let filter of this._knownFilters) 40 for (let filter of this._knownFilters)
Manish Jethani 2018/05/17 05:51:54 Note: I am not yet taking advantage of the optimiz
41 { 41 {
42 if (filter.isActiveOnDomain(domain) && 42 if (filter.isActiveOnDomain(domain) &&
43 !ElemHideExceptions.getException(filter, domain)) 43 !ElemHideExceptions.getException(filter.selector, domain))
44 { 44 {
45 result.push(filter); 45 result.push(filter);
46 } 46 }
47 } 47 }
48 return result; 48 return result;
49 } 49 }
50 }); 50 });
LEFTRIGHT

Powered by Google App Engine
This is Rietveld