Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: test/filterListener.js

Issue 29784555: Issue 6665 - Abstract element hiding container logic into its own module Base URL: https://hg.adblockplus.org/adblockpluscore/
Patch Set: Rebase Created May 17, 2018, 5:31 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« lib/elemHideEmulation.js ('K') | « lib/elemHideEmulation.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/filterListener.js
===================================================================
--- a/test/filterListener.js
+++ b/test/filterListener.js
@@ -24,22 +24,17 @@
let Subscription = null;
let Filter = null;
let defaultMatcher = null;
let SpecialSubscription = null;
let ElemHideException = null;
exports.setUp = function(callback)
{
- sandboxedRequire = createSandbox({
- extraExports: {
- elemHide: ["knownFilters"],
- elemHideEmulation: ["filters"]
- }
- });
+ sandboxedRequire = createSandbox();
// We need to require the filterListener module so that filter changes will be
// noticed, even though we don't directly use the module here.
sandboxedRequire("../lib/filterListener");
(
{FilterStorage} = sandboxedRequire("../lib/filterStorage"),
{Subscription, SpecialSubscription} = sandboxedRequire("../lib/subscriptionClasses"),
@@ -76,28 +71,28 @@
}
}
result[type] = filters;
}
let elemHide = sandboxedRequire("../lib/elemHide");
result.elemhide = [];
result.elemhideexception = [];
- for (let filter of elemHide.knownFilters)
+ for (let filter of elemHide.ElemHide._knownFilters)
{
if (filter instanceof ElemHideException)
result.elemhideexception.push(filter.text);
else
result.elemhide.push(filter.text);
}
let elemHideEmulation = sandboxedRequire("../lib/elemHideEmulation");
result.elemhideemulation = [];
- for (let filterText of elemHideEmulation.filters)
- result.elemhideemulation.push(filterText);
+ for (let filter of elemHideEmulation.ElemHideEmulation._knownFilters)
+ result.elemhideemulation.push(filter.text);
let types = ["blacklist", "whitelist", "elemhide", "elemhideexception",
"elemhideemulation"];
for (let type of types)
{
if (!(type in expected))
expected[type] = [];
else
« lib/elemHideEmulation.js ('K') | « lib/elemHideEmulation.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld