Issue 29784585: Issue 6675 - Don't use relative path for info module require

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 29784585: Issue 6675 - Don't use relative path for info module require (Closed)

Created:
May 17, 2018, 1:48 p.m. by kzar

Modified:
May 17, 2018, 2:26 p.m.

Reviewers:
Sebastian Noack

CC:
tlucas

Visibility:
Public.

Description

Issue 6675 - Don't use relative path for info module require

Patch Set 1 #

Created: May 17, 2018, 1:48 p.m.

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	lib/cssInjection.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/filterComposer.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/options.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/prefs.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/subscriptionInit.js	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/uninstall.js	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

Sebastian Noack

LGTM. But what is about adblockplusui and adblockpluscore?

May 17, 2018, 2:01 p.m. (2018-05-17 14:01:26 UTC) #3

kzar

On 2018/05/17 14:01:26, Sebastian Noack wrote: > LGTM. But what is about adblockplusui and adblockpluscore? ...

May 17, 2018, 2:11 p.m. (2018-05-17 14:11:57 UTC) #4

Sebastian Noack

May 17, 2018, 2:26 p.m. (2018-05-17 14:26:17 UTC) #5

Message was sent while issue was closed.

On 2018/05/17 14:11:57, kzar wrote:
> In adblockpluscore everyone disagreed with me about using relative paths for
> modules in the parent directory, so we don't use a relative path for the info
> module. In adblockplusui we don't yet use relative paths yet, but Jon has a
> review open to add them and I already left a comment there asking him to not
use
> relative paths for the info module.

I see. Sounds good.

Expand All Messages | Collapse All Messages