Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(250)

Issue 29784585: Issue 6675 - Don't use relative path for info module require (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 3 months ago by kzar
Modified:
1 year, 3 months ago
Reviewers:
Sebastian Noack
CC:
tlucas
Visibility:
Public.

Description

Issue 6675 - Don't use relative path for info module require

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M lib/cssInjection.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/filterComposer.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/options.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/prefs.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/subscriptionInit.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/uninstall.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
kzar
1 year, 3 months ago (2018-05-17 13:50:11 UTC) #1
kzar
Patch Set 1
1 year, 3 months ago (2018-05-17 13:50:24 UTC) #2
Sebastian Noack
LGTM. But what is about adblockplusui and adblockpluscore?
1 year, 3 months ago (2018-05-17 14:01:26 UTC) #3
kzar
On 2018/05/17 14:01:26, Sebastian Noack wrote: > LGTM. But what is about adblockplusui and adblockpluscore? ...
1 year, 3 months ago (2018-05-17 14:11:57 UTC) #4
Sebastian Noack
1 year, 3 months ago (2018-05-17 14:26:17 UTC) #5
Message was sent while issue was closed.
On 2018/05/17 14:11:57, kzar wrote:
> In adblockpluscore everyone disagreed with me about using relative paths for
> modules in the parent directory, so we don't use a relative path for the info
> module. In adblockplusui we don't yet use relative paths yet, but Jon has a
> review open to add them and I already left a comment there asking him to not
use
> relative paths for the info module.

I see. Sounds good.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5