Issue 6684 - Issue Reporter Active Tab Screenshot

popup.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 85 matching lines @@
   {
     window.clearTimeout(activateClickHide.timeout);
     activateClickHide.timeout = null;
   }
   document.body.classList.remove("clickhide-active");
   browser.tabs.sendMessage(tab.id, {type: "composer.content.finished"});
 }
 
 function reportIssue()
 {
-  // capture the current visible tab

[Sebastian Noack, 2018/05/23 14:48:59]

Nit: This comment seems superfluous (it essentially reads like the source code
in the line below).

[a.giammarchi, 2018/05/23 15:06:35]

Done.

-  browser.tabs.captureVisibleTab(
-    null,
-    {format: "png"},
-    (screenshot) =>

[Sebastian Noack, 2018/05/23 14:48:59]

Nit: We omit the optional parenthesis in arrow functions with a single argument.

[a.giammarchi, 2018/05/23 15:06:35]

Done.

-    {
-      // setup a listener to provide once tab url
-      // and base64 screenshot data once asked
-      browser.runtime.onMessage.addListener(
-        function onMessage(event)
-        {
-          if (event.type === "issue-reporter")

[Sebastian Noack, 2018/05/23 14:48:59]

Nit: We prefer == over ===, as per the Mozilla coding style guide which our
coding style guide is based on.

[a.giammarchi, 2018/05/23 15:06:35]

Done.

-          {
-            browser.runtime.onMessage.removeListener(onMessage);
-            return Promise.resolve({url: tab.url, screenshot});
-          }
-        }
-      );
-
-      // create an active/selected issue reporter tab

[Sebastian Noack, 2018/05/23 14:48:59]

Nit: This comment seems superfluous as well.

[a.giammarchi, 2018/05/23 15:06:36]

Done.

-      browser.tabs.create({
-        active: true,
-        url: browser.runtime.getURL("/issue-reporter.html?" + tab.id)
-      });
-    }
-  );
+  // the issue reporter needs to take a screenshot of the
+  // currently active tab, which is why active is explicitly
+  // set as false, in case option defaults will ever change.
+  browser.tabs.create({
+    active: false,
+    url: browser.runtime.getURL("/issue-reporter.html?" + tab.id)
+  }).then(() =>
+  {
+    window.close();
+  });
 }
 
 function toggleCollapse(event)
 {
   let collapser = event.currentTarget;
   let collapsible = document.getElementById(collapser.dataset.collapsible);
   collapsible.classList.toggle("collapsed");
   togglePref(collapser.dataset.option);
 }
 
@@ skipping 210 matching lines @@
       {
         if (event.target.id == "notification-optout")
           setPref("notifications_ignoredcategories", true);
 
         notificationElement.hidden = true;
         browser.runtime.sendMessage({type: "notifications.clicked"});
       }
     }, true);
   });
 });