Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29785558: Issue 6679 - Don't show block stats in icon if disabled (Closed)

Created:
May 18, 2018, 10:39 a.m. by kzar
Modified:
May 18, 2018, 12:51 p.m.
Visibility:
Public.

Description

Issue 6679 - Don't show block stats in icon if disabled

Patch Set 1 #

Total comments: 2

Patch Set 2 : Split logic out into separate function #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -26 lines) Patch
M lib/stats.js View 1 4 chunks +17 lines, -26 lines 0 comments Download

Messages

Total messages: 5
kzar
Patch Set 1
May 18, 2018, 10:40 a.m. (2018-05-18 10:40:53 UTC) #1
Thomas Greiner
The change works, just a comment about further improving it to avoid similar issues in ...
May 18, 2018, 10:50 a.m. (2018-05-18 10:50:18 UTC) #2
kzar
Patch Set 2 : Split logic out into separate function https://codereview.adblockplus.org/29785558/diff/29785559/lib/stats.js File lib/stats.js (right): https://codereview.adblockplus.org/29785558/diff/29785559/lib/stats.js#newcode49 ...
May 18, 2018, 12:25 p.m. (2018-05-18 12:25:30 UTC) #3
Thomas Greiner
LGTM
May 18, 2018, 12:30 p.m. (2018-05-18 12:30:16 UTC) #4
Sebastian Noack
May 18, 2018, 12:48 p.m. (2018-05-18 12:48:16 UTC) #5
LGTM

Powered by Google App Engine
This is Rietveld