Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29785567: #11294 - Generate and store anonymized HTTPd logs (Closed)

Created:
May 18, 2018, 3:16 p.m. by mathias
Modified:
July 16, 2018, 3:58 p.m.
Reviewers:
f.lopez, Fred
Visibility:
Public.

Description

#11294 - Generate and store anonymized HTTPd logs

Patch Set 1 #

Total comments: 1

Patch Set 2 : #11294 - Remove $adblockplus::web::server::geoip parameter #

Patch Set 3 : #11294 - Include input MD5 sum with archive file names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -12 lines) Patch
M hiera/roles/web/adblockplus.yaml View 1 1 chunk +0 lines, -1 line 0 comments Download
M modules/nginx/manifests/init.pp View 1 3 chunks +13 lines, -0 lines 0 comments Download
M modules/nginx/templates/logrotate.erb View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M modules/private-stub/hiera/base.yaml View 1 2 chunks +3 lines, -1 line 0 comments Download
M modules/web/manifests/server.pp View 1 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 6
mathias
May 18, 2018, 3:16 p.m. (2018-05-18 15:16:18 UTC) #1
f.lopez
LGTM
May 18, 2018, 7:01 p.m. (2018-05-18 19:01:26 UTC) #2
Fred
https://codereview.adblockplus.org/29785567/diff/29785568/modules/web/manifests/server.pp File modules/web/manifests/server.pp (right): https://codereview.adblockplus.org/29785567/diff/29785568/modules/web/manifests/server.pp#newcode10 modules/web/manifests/server.pp:10: $geoip = false, Do we still need this parameter?
May 25, 2018, 9:48 a.m. (2018-05-25 09:48:04 UTC) #3
mathias
June 5, 2018, 1:46 p.m. (2018-06-05 13:46:25 UTC) #4
mathias
June 5, 2018, 2:29 p.m. (2018-06-05 14:29:10 UTC) #5
Fred
June 6, 2018, 7:16 a.m. (2018-06-06 07:16:54 UTC) #6
LGTM

Powered by Google App Engine
This is Rietveld