Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29793555: Issue 6704 - Prevent $rewrite filters from matching against request types that load code (Closed)

Created:
May 29, 2018, 1:21 p.m. by Sebastian Noack
Modified:
May 29, 2018, 2:41 p.m.
Reviewers:
kzar
CC:
hub, Manish Jethani
Visibility:
Public.

Description

Issue 6704 - Prevent $rewrite filters from matching against request types that load code

Patch Set 1 #

Patch Set 2 : Added OBJECT_SUBREQUEST #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M lib/filterClasses.js View 1 1 chunk +12 lines, -0 lines 0 comments Download
M test/filterClasses.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
Sebastian Noack
As discussed on IRC. Will still file an issue for this change, and then update ...
May 29, 2018, 1:22 p.m. (2018-05-29 13:22:07 UTC) #1
Sebastian Noack
May 29, 2018, 1:50 p.m. (2018-05-29 13:50:21 UTC) #2
Sebastian Noack
May 29, 2018, 2:09 p.m. (2018-05-29 14:09:57 UTC) #3
kzar
Like we discussed I'd prefer we revert $rewrite instead, but the changes themselves LGTM since ...
May 29, 2018, 2:29 p.m. (2018-05-29 14:29:38 UTC) #4
Sebastian Noack
May 29, 2018, 2:34 p.m. (2018-05-29 14:34:08 UTC) #5
On 2018/05/29 14:29:38, kzar wrote:
> Please could you add testing hints to 6622 or the new dependency update issue
> with some examples though? I think it's not obvious how to test this change
> otherwise.

Done.

Powered by Google App Engine
This is Rietveld