Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(972)

Issue 29793567: Issue 6706 - Make "build.py updatepsl" encode domains as Punycode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by Sebastian Noack
Modified:
1 year, 5 months ago
Reviewers:
tlucas
Visibility:
Public.

Description

Issue 6706 - Make "build.py updatepsl" encode domains as Punycode

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M publicSuffixListUpdater.py View 1 chunk +10 lines, -4 lines 0 comments Download

Messages

Total messages: 2
Sebastian Noack
For reference, I went ahead running "build.py updatepsl" with this patch applied already, so that ...
1 year, 5 months ago (2018-05-29 15:20:02 UTC) #1
tlucas
1 year, 5 months ago (2018-05-29 15:36:23 UTC) #2
On 2018/05/29 15:20:02, Sebastian Noack wrote:
> For reference, I went ahead running "build.py updatepsl" with this patch
applied
> already, so that the upcoming release isn't blocked by the buildtools change:
> https://hg.adblockplus.org/adblockpluschrome/rev/6b48442e0a00

Alright - LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5