Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(243)

Issue 29793570: Issue 6692 - Update frame structure for about:blank frames earlier (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by kzar
Modified:
1 year, 2 months ago
Reviewers:
Sebastian Noack
Visibility:
Public.

Description

Issue 6692 - Update frame structure for about:blank frames earlier

Patch Set 1 #

Total comments: 2

Patch Set 2 : Only handle about:blank #

Total comments: 4

Patch Set 3 : Addressed nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M ext/background.js View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 6
kzar
Patch Set 1
1 year, 2 months ago (2018-05-29 16:47:42 UTC) #1
Sebastian Noack
https://codereview.adblockplus.org/29793570/diff/29793571/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29793570/diff/29793571/ext/background.js#newcode268 ext/background.js:268: if (!(url.startsWith("http:") || Wouldn't checking for "about:blank" be sufficient ...
1 year, 2 months ago (2018-05-29 16:48:49 UTC) #2
kzar
Patch Set 2 : Only handle about:blank https://codereview.adblockplus.org/29793570/diff/29793571/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29793570/diff/29793571/ext/background.js#newcode268 ext/background.js:268: if (!(url.startsWith("http:") ...
1 year, 2 months ago (2018-05-29 17:28:12 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29793570/diff/29793578/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29793570/diff/29793578/ext/background.js#newcode280 ext/background.js:280: // order to properly attribute the requests they make. ...
1 year, 2 months ago (2018-05-29 17:35:09 UTC) #4
kzar
Patch Set 3 : Addressed nits https://codereview.adblockplus.org/29793570/diff/29793578/ext/background.js File ext/background.js (right): https://codereview.adblockplus.org/29793570/diff/29793578/ext/background.js#newcode280 ext/background.js:280: // order to ...
1 year, 2 months ago (2018-05-29 17:46:18 UTC) #5
Sebastian Noack
1 year, 2 months ago (2018-05-29 17:56:34 UTC) #6
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5