Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(302)

Issue 29793573: Issue 6701 - Implement CSP support in python-abp (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 months, 3 weeks ago by rhowell
Modified:
3 months, 2 weeks ago
Base URL:
https://hg.adblockplus.org/python-abp/
Visibility:
Public.

Description

Issue 6701 - Implement CSP support in python-abp

Patch Set 1 #

Total comments: 7

Patch Set 2 : Remove validity regex and extraneous comment #

Patch Set 3 : Check negation first, and added some tests #

Total comments: 6

Patch Set 4 : Condense the tests, properly handle ~csp #

Patch Set 5 : Removing handling and testing for ~csp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M abp/filters/parser.py View 1 3 4 2 chunks +2 lines, -1 line 0 comments Download
M tests/test_parser.py View 1 2 3 4 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 17
rhowell
4 months, 3 weeks ago (2018-05-29 16:54:36 UTC) #1
rhowell
On 2018/05/29 16:54:36, rhowell wrote: Hey Vasily, Wanted to get your feedback so far. Am ...
4 months, 3 weeks ago (2018-05-29 16:59:46 UTC) #2
Vasily Kuznetsov
Hi Rosie, The start looks good. I think you would need to add a test ...
4 months, 3 weeks ago (2018-05-30 19:49:26 UTC) #3
rhowell
I talked with Dave about the ~csp=xxxx option, see below for comments. Thanks! :) https://codereview.adblockplus.org/29793573/diff/29793574/abp/filters/parser.py ...
4 months, 2 weeks ago (2018-06-07 18:16:55 UTC) #4
Vasily Kuznetsov
Thanks for clearing this up with Dave, Rosie, see my comment below. https://codereview.adblockplus.org/29793573/diff/29793574/abp/filters/parser.py File abp/filters/parser.py ...
4 months, 2 weeks ago (2018-06-07 18:28:31 UTC) #5
rhowell
I added tests similar to what Dave was testing in adblockpluscore. Let me know if ...
4 months, 2 weeks ago (2018-06-07 23:13:06 UTC) #6
Vasily Kuznetsov
Hi Rosie, I think it's bit of an overkill but not too much. Maybe we ...
4 months, 1 week ago (2018-06-08 16:41:49 UTC) #7
rhowell
Hey Vasily, Thanks for the feedback. In parser.py, it feels a little hacky to hardcode ...
4 months, 1 week ago (2018-06-12 21:13:18 UTC) #8
Vasily Kuznetsov
On 2018/06/12 21:13:18, rhowell wrote: > Hey Vasily, > > Thanks for the feedback. In ...
4 months, 1 week ago (2018-06-13 14:01:57 UTC) #9
Sebastian Noack
On 2018/06/13 14:01:57, Vasily Kuznetsov wrote: > I think we can make this apply to ...
4 months, 1 week ago (2018-06-13 18:07:18 UTC) #10
Vasily Kuznetsov
On 2018/06/13 18:07:18, Sebastian Noack wrote: > On 2018/06/13 14:01:57, Vasily Kuznetsov wrote: > > ...
4 months, 1 week ago (2018-06-13 22:21:13 UTC) #11
Sebastian Noack
On 2018/06/13 22:21:13, Vasily Kuznetsov wrote: > I agree that treating "~xxx=yyy" as "some-unknown-option" is ...
4 months, 1 week ago (2018-06-14 02:36:49 UTC) #12
Vasily Kuznetsov
On 2018/06/14 02:36:49, Sebastian Noack wrote: > On 2018/06/13 22:21:13, Vasily Kuznetsov wrote: > > ...
4 months, 1 week ago (2018-06-14 09:26:44 UTC) #13
Sebastian Noack
On 2018/06/14 09:26:44, Vasily Kuznetsov wrote: > Sure, if there's no actual use case for ...
4 months, 1 week ago (2018-06-14 18:41:59 UTC) #14
Vasily Kuznetsov
On 2018/06/14 18:41:59, Sebastian Noack wrote: > On 2018/06/14 09:26:44, Vasily Kuznetsov wrote: > > ...
4 months, 1 week ago (2018-06-14 19:10:41 UTC) #15
rhowell
On 2018/06/14 19:10:41, Vasily Kuznetsov wrote: > On 2018/06/14 18:41:59, Sebastian Noack wrote: > > ...
4 months, 1 week ago (2018-06-14 19:49:39 UTC) #16
Vasily Kuznetsov
4 months, 1 week ago (2018-06-14 21:01:20 UTC) #17
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5