#11421 - Redirect broken links on adblockbrowser.org

hiera/roles/web/adblockbrowser.yaml

 classes:
   adblockplus::web::mimeo:
     format: $remote_addr - - [$time_local] "$request" $status $bytes_sent "$http_referer" "$http_user_agent" "$http_x_forwarded_for" - "$http_accept_language" "$http_host" "$http_x_client_id" $http_content_length "$http_content_type" $request_body
     response: All good, carry on!
     port: 8000
   web::server:
     vhost: adblockbrowser.org
     aliases:
       - www.adblockbrowser.org
     is_default: true
@@ skipping 17 matching lines @@
       rewrite ^/zh-CN/?$ https://adblockbrowser.org/zh_CN/ permanent;
       rewrite ^/android-support/removing-filter-list/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/ios-support/install/?$ https://adblockplus.org/forum/viewforum.php?f=26 permanent;
       rewrite ^/android-support/display-options/?^ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/blog/?$ https://adblockplus.org/blog/ permanent;
       rewrite ^/zh-CN/android-support/customizing-abb/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/pt-BR/android-support/acceptable-ads-config/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/es-ES/android-support/changing-language/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/es-ES/android-support/removing-filter-list/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/index.html https://adblockbrowser.org/ permanent;
-      rewrite ^/ios-support/?$ https://adblockplus.org/forum/viewforum.php?f=26 permanent;
       rewrite ^/android/? https://adblockplus.org/forum/viewforum.php?f=15 permanent;
-      rewrite ^/zh-CN/android-support/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/pt-PT/android-support/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/ios-support/removing-filter-list/?$ https://adblockplus.org/forum/viewforum.php?f=26 permanent;
       rewrite ^/zh-CN/android-support/adding-filter-list/?$ https://adblockplus.org/forum/viewforum.php?f=15 permanent;
       rewrite ^/zh-TW/ios-support/install/?$ https://adblockplus.org/forum/viewforum.php?f=26 permanent;
-      location /forum/viewforum {

[mathias, 2018/05/30 07:45:28]

Can't we just re-write all /forum/viewforum and /forum/viewtopic requests to go
for adblockplus.org/forum/...? I mean forget about the $arg_* conditions
altogether?

[f.lopez, 2018/05/30 19:03:41]

Yes we can, I did it this way to make it as verbose as possible, but I can
reduce it to a few lines, gonna change it for the next patch

-        if ($arg_f = "22")
-        {
-          rewrite ^(.*)/?$ https://adblockplus.org/forum/viewforum.php permanent;
-        }
-      }
-      location /forum/viewtopic {
-        set $arguments $arg_f/$arg_t/$arg_start;
-        if ($arguments = "2/40190/")
-        {
-          rewrite ^(.*) https://adblockplus.org/forum/viewtopic.php permanent;
-        }
-        if ($arguments = "2/36849/")
-        {
-          rewrite ^(.*) https://adblockplus.org/forum/viewtopic.php permanent;
-        }
-        if ($arguments = "1/23617/")
-        {
-          rewrite ^(.*) https://adblockplus.org/forum/viewtopic.php permanent;
-        }
-        if ($arguments = "9/40312/")
-        {
-          rewrite ^(.*) https://adblockplus.org/forum/viewtopic.php permanent;
-        }
-        if ($arguments = "18/21550/15")
-        {
-          rewrite ^(.*) https://adblockplus.org/forum/viewtopic.php permanent;
-        }
+      location ~ /forum/view(forum|topic) {
+       rewrite ^/forum/view(forum|topic) https://adblockplus.org/forum/view$1.php permanent;
       }
       location /submit-feedback {
         proxy_pass http://127.0.0.1:8000;
         proxy_set_header User-Agent $http_user_agent;
         proxy_set_header Referer $http_referer;
         proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
         proxy_set_header Accept-Language $http_accept_language;
         proxy_set_header Host $http_host;
         proxy_set_header X-Client-Id $http_x_client_id;
       }
@@ skipping 23 matching lines @@
 sitescripts::configfragments:
   installation_link:
     content: |
       [DEFAULT]
       mailer=/usr/sbin/sendmail
       [multiplexer]
       sitescripts.send_installation_link.web.send_installation_link =
       [send_installation_link]
       email_template=send_installation_link/template/adblockbrowser_installation_link.tmpl