Issue 6490 - Wrap browser.browserAction.set* with Promise

polyfill.js

Index: polyfill.js
===================================================================
--- a/polyfill.js
+++ b/polyfill.js
@@ -14,16 +14,19 @@
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 {
   const asyncAPIs = [
+    "browserAction.setIcon",
+    "browserAction.setBadgeText",
+    "browserAction.setBadgeBackgroundColor",

[Jon Sonesen, 2018/07/10 23:01:08]

chromium-browser==66.0.3359.181-0ubuntu0.18.04.1 complains that the invocation
of all the set methods doesn't meet the parameter signature, reporting that it
is defined as `set*(object details)` not `set*(object details, function)`.
However, Chrome does not complain and neither does Chromium 67. So I am not sure
what is going on there or if it is of importance.

     "browserAction.getPopup",
     "contextMenus.removeAll",
     "devtools.panels.create",
     "notifications.clear",
     "notifications.create",
     "runtime.getBrowserInfo",
     "runtime.openOptionsPage",
     "runtime.sendMessage",