Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29794555: Noissue - Fix broken layout from changeset 1940351cdb4c (Closed)

Created:
May 30, 2018, 10:17 a.m. by ire
Modified:
May 30, 2018, 12:57 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.acceptableads.com
Visibility:
Public.

Description

Noissue - Fix broken layout from changeset 1940351cdb4c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+222 lines, -84 lines) Patch
M static/css/main.css View 5 chunks +48 lines, -25 lines 0 comments Download
M static/js/main.js View 2 chunks +62 lines, -7 lines 0 comments Download
M static/scss/_variables.scss View 2 chunks +11 lines, -1 line 0 comments Download
M static/scss/layout/_body.scss View 1 chunk +32 lines, -22 lines 0 comments Download
M static/scss/layout/_breadcrumbs.scss View 2 chunks +14 lines, -4 lines 0 comments Download
M static/scss/layout/_navbar.scss View 2 chunks +21 lines, -4 lines 0 comments Download
M static/scss/layout/_sidebar.scss View 2 chunks +34 lines, -21 lines 0 comments Download

Messages

Total messages: 5
ire
May 30, 2018, 10:17 a.m. (2018-05-30 10:17:40 UTC) #1
ire
Ready for review What I did was first re-apply Jael's patch then made some changes ...
May 30, 2018, 10:20 a.m. (2018-05-30 10:20:55 UTC) #2
juliandoucette
On 2018/05/30 10:20:55, ire wrote: > Ready for review > > What I did was ...
May 30, 2018, 12:08 p.m. (2018-05-30 12:08:57 UTC) #3
ire
On 2018/05/30 12:08:57, juliandoucette wrote: > On 2018/05/30 10:20:55, ire wrote: > > Ready for ...
May 30, 2018, 12:53 p.m. (2018-05-30 12:53:55 UTC) #4
ire
May 30, 2018, 12:57 p.m. (2018-05-30 12:57:53 UTC) #5
Message was sent while issue was closed.
Commits:

- [Noissue - Fix broken layout from changeset
1940351cdb4c](https://hg.adblockplus.org/web.acceptableads.com/rev/19f4e3949577)
(Ire Aderinokun)
- [Fixes #6 - Unfix primary
navigation](https://hg.adblockplus.org/web.acceptableads.com/rev/d2d8b369d2e9)
(Yael Stein)

Powered by Google App Engine
This is Rietveld