Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29795555: #11738 - Add redirects for Acceptable Ads optout and ABP terms (Closed)

Created:
May 31, 2018, 10:47 a.m. by mathias
Modified:
June 4, 2018, 1:38 p.m.
Reviewers:
f.lopez
CC:
Fred
Visibility:
Public.

Description

#11738 - Add redirects for Acceptable Ads optout and ABP terms

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M hiera/roles/web/redirect/eyeo.yaml View 1 chunk +2 lines, -1 line 2 comments Download

Messages

Total messages: 4
mathias
May 31, 2018, 10:47 a.m. (2018-05-31 10:47:13 UTC) #1
f.lopez
https://codereview.adblockplus.org/29795555/diff/29795556/hiera/roles/web/redirect/eyeo.yaml File hiera/roles/web/redirect/eyeo.yaml (right): https://codereview.adblockplus.org/29795555/diff/29795556/hiera/roles/web/redirect/eyeo.yaml#newcode59 hiera/roles/web/redirect/eyeo.yaml:59: adblockplus/terms: "https://adblockplus.org/terms" will you remove the new line at ...
May 31, 2018, 7:17 p.m. (2018-05-31 19:17:38 UTC) #2
mathias
https://codereview.adblockplus.org/29795555/diff/29795556/hiera/roles/web/redirect/eyeo.yaml File hiera/roles/web/redirect/eyeo.yaml (right): https://codereview.adblockplus.org/29795555/diff/29795556/hiera/roles/web/redirect/eyeo.yaml#newcode59 hiera/roles/web/redirect/eyeo.yaml:59: adblockplus/terms: "https://adblockplus.org/terms" On 2018/05/31 19:17:38, f.lopez wrote: > will ...
June 1, 2018, 7:41 a.m. (2018-06-01 07:41:22 UTC) #3
f.lopez
June 2, 2018, 5:27 p.m. (2018-06-02 17:27:08 UTC) #4
On 2018/06/01 07:41:22, mathias wrote:
>
https://codereview.adblockplus.org/29795555/diff/29795556/hiera/roles/web/red...
> File hiera/roles/web/redirect/eyeo.yaml (right):
> 
>
https://codereview.adblockplus.org/29795555/diff/29795556/hiera/roles/web/red...
> hiera/roles/web/redirect/eyeo.yaml:59: adblockplus/terms:
> "https://adblockplus.org/terms"
> On 2018/05/31 19:17:38, f.lopez wrote:
> > will you remove the new line at the end of the file too?
> 
> Yes, in this case actually by intention. Objections?

It is an unrelated change, I'd like to keep consistency and don't push unrelated
changes but I leave it up to you so it LGTM

Powered by Google App Engine
This is Rietveld