Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29795567: #11371 - Password protection for fileserver repositories (Closed)

Created:
May 31, 2018, 4:19 p.m. by f.lopez
Modified:
June 6, 2018, 4:09 p.m.
Reviewers:
mathias, Fred
Visibility:
Public.

Description

#11371 - Password protection for fileserver repositories

Patch Set 1 #

Patch Set 2 : Didnt remove unnecessary file #

Patch Set 3 : Uploaded a file by mistake #

Total comments: 6

Patch Set 4 : For comment 4 #

Total comments: 4

Patch Set 5 : For comment 7 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
R modules/adblockplus/files/nginx/fileserver.conf View 1 1 chunk +0 lines, -3 lines 0 comments Download
M modules/adblockplus/manifests/web/fileserver.pp View 1 2 3 2 chunks +4 lines, -11 lines 0 comments Download
M modules/adblockplus/manifests/web/fileserver/repository.pp View 1 2 3 4 2 chunks +20 lines, -0 lines 0 comments Download
A modules/adblockplus/templates/web/fileserver.conf.erb View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10
f.lopez
May 31, 2018, 4:19 p.m. (2018-05-31 16:19:56 UTC) #1
f.lopez
May 31, 2018, 4:20 p.m. (2018-05-31 16:20:46 UTC) #2
f.lopez
June 1, 2018, 5:02 p.m. (2018-06-01 17:02:57 UTC) #3
mathias
I like the approach a lot, just some caveats to address here. https://codereview.adblockplus.org/29795567/diff/29796572/modules/adblockplus/manifests/web/fileserver/repository.pp File modules/adblockplus/manifests/web/fileserver/repository.pp ...
June 1, 2018, 9:14 p.m. (2018-06-01 21:14:42 UTC) #4
f.lopez
https://codereview.adblockplus.org/29795567/diff/29796572/modules/adblockplus/manifests/web/fileserver/repository.pp File modules/adblockplus/manifests/web/fileserver/repository.pp (right): https://codereview.adblockplus.org/29795567/diff/29796572/modules/adblockplus/manifests/web/fileserver/repository.pp#newcode27 modules/adblockplus/manifests/web/fileserver/repository.pp:27: $auth_users = [], On 2018/06/01 21:14:41, mathias wrote: > ...
June 2, 2018, 6:29 p.m. (2018-06-02 18:29:41 UTC) #5
f.lopez
June 2, 2018, 9:04 p.m. (2018-06-02 21:04:58 UTC) #6
mathias
https://codereview.adblockplus.org/29795567/diff/29797555/modules/adblockplus/manifests/web/fileserver/repository.pp File modules/adblockplus/manifests/web/fileserver/repository.pp (right): https://codereview.adblockplus.org/29795567/diff/29797555/modules/adblockplus/manifests/web/fileserver/repository.pp#newcode50 modules/adblockplus/manifests/web/fileserver/repository.pp:50: }, $auth_file)) This might be undef now, to indicate ...
June 5, 2018, 3:02 p.m. (2018-06-05 15:02:58 UTC) #7
f.lopez
https://codereview.adblockplus.org/29795567/diff/29797555/modules/adblockplus/manifests/web/fileserver/repository.pp File modules/adblockplus/manifests/web/fileserver/repository.pp (right): https://codereview.adblockplus.org/29795567/diff/29797555/modules/adblockplus/manifests/web/fileserver/repository.pp#newcode50 modules/adblockplus/manifests/web/fileserver/repository.pp:50: }, $auth_file)) On 2018/06/05 15:02:58, mathias wrote: > This ...
June 5, 2018, 6 p.m. (2018-06-05 18:00:44 UTC) #8
f.lopez
June 5, 2018, 6:47 p.m. (2018-06-05 18:47:49 UTC) #9
mathias
June 6, 2018, 7:21 a.m. (2018-06-06 07:21:11 UTC) #10
LGTM.

Powered by Google App Engine
This is Rietveld