#11371 - Password protection for fileserver repositories

modules/adblockplus/manifests/web/fileserver/repository.pp

 # == Type: adblockplus::web::fileserver::repository
 #
 # Manage a repository on a fileserver.
 #
 # A repository is a site where a group of people can upload and artifacts.
 #
 # In its current form, a repository is simply a directory exposed on a web
 # server. This may evolve to make use of more advanced repositories in the
 # future (proxy to repository manager, or 3rd-party service, etc).
 #
@@ skipping 27 matching lines @@
   $auth_filename = "${::adblockplus::directory}/htpasswd/${name}"
 
   nginx::hostconfig {"$repository_host":
     content => template("adblockplus/web/fileserver.conf.erb"),
     is_default => false,
     certificate => $adblockplus::web::fileserver::certificate,
     private_key => $adblockplus::web::fileserver::private_key,
     log => 'access_log_fileserver',
   }
 
-  ensure_resource('file', $auth_filename, merge({
-    ensure => ensure_file_state($ensure),
-  }, $auth_file))

[mathias, 2018/06/05 15:02:58]

This might be undef now, to indicate that there's no authentication setup, hence
it requires a conditional statement or similar.

[f.lopez, 2018/06/05 18:00:44]

Acknowledged.

+  if $auth_file != undef {
+    ensure_resource('file', $auth_filename, merge({
+      ensure => ensure_file_state($ensure),
+    }, $auth_file))
+  }
 
   group {"$group_name":
     ensure => $ensure,
   }
 
   file {"$repository_directory":
     ensure => ensure_directory_state($ensure),
     group => $group_name,
     mode => '0775',
     require => [
@@ skipping 10 matching lines @@
 
   realize(File[$adblockplus::directory])
 
   file {"/var/www/$repository_host":
     ensure => ensure_symlink_state($ensure),
     target => "$repository_directory",
     require => File["$repository_directory"],
   }
 }