metadata.edge - Issue 29796555: Issue 6621

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Side by Side Diff: metadata.edge

Issue 29796555: Issue 6621 (Closed)

Patch Set: Created June 1, 2018, 1:58 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View unified diff | Download patch

OLD	NEW
1 [default]	1 [default]
	Sebastian Noack 2018/06/01 19:15:46 Thanks for fixing the newlines here (this file use Thanks for fixing the newlines here (this file used CRLF while all other files use UNIX newlines). However, this makes it difficult to review the relevant changes in here. So I went ahead, and fixed the newlines in a separate commit: https://hg.adblockplus.org/adblockpluschrome/rev/b177288cd22a Please rebase on top of the "next" branch. Afterwards the only changes in here should be the added [module_alias] section.
2 inherit = metadata.chrome	2 inherit = metadata.chrome

3	3

4 [general]	4 [general]

5 version = 0.9.11	5 version = 0.9.11

6 basename = adblockplusedge	6 basename = adblockplusedge

7 app_id_release = EyeoGmbH.AdblockPlus	7 app_id_release = EyeoGmbH.AdblockPlus

8 app_id_devbuild = EyeoGmbH.AdblockPlusdevelopmentbuild	8 app_id_devbuild = EyeoGmbH.AdblockPlusdevelopmentbuild

9 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88	9 publisher_id = CN=4F066043-8AFE-41C9-B762-6C15E77E3F88

10 background_color = red	10 background_color = red

11 extension_id_release = 1.0	11 extension_id_release = 1.0

12	12

	13 [module_alias]

	14 io$ = ioIndexedDB

	15

	16 [bundles]

	17 qunit/tests.js += qunit/tests/ioIndexedDB.js
	kzar 2018/06/04 11:06:07 Really cool you took the extra time to write some Really cool you took the extra time to write some tests. kzar 2018/06/04 18:06:56 Looks like the fact that the qunit/tests.js bundle Show quoted text On 2018/06/04 11:06:07, kzar wrote: > Really cool you took the extra time to write some tests. Looks like the fact that the qunit/tests.js bundle is listed in the metadata file at all was a bug. So once the change for #6720 lands your new tests should be bundled and included automatically. piscoi.georgiana 2018/06/05 07:15:56 I'll keep an eye out for the change and update acc Show quoted text On 2018/06/04 18:06:56, kzar wrote: > On 2018/06/04 11:06:07, kzar wrote: > > Really cool you took the extra time to write some tests. > > Looks like the fact that the qunit/tests.js bundle is listed in the metadata > file at all was a bug. So once the change for #6720 lands your new tests should > be bundled and included automatically. I'll keep an eye out for the change and update accordingly piscoi.georgiana 2018/06/11 07:02:44 Done. Show quoted text On 2018/06/04 18:06:56, kzar wrote: > On 2018/06/04 11:06:07, kzar wrote: > > Really cool you took the extra time to write some tests. > > Looks like the fact that the qunit/tests.js bundle is listed in the metadata > file at all was a bug. So once the change for #6720 lands your new tests should > be bundled and included automatically. Done.
	18

13 [compat]	19 [compat]

14 edge = 41.16299.0.0	20 edge = 41.16299.0.0

15 windows = 10.0.16299.0/12.0.0.0	21 windows = 10.0.16299.0/12.0.0.0

16	22

17 [appx_assets]	23 [appx_assets]

18 logo_44.png = icons/abp-44.png	24 logo_44.png = icons/abp-44.png

19 logo_50.png = icons/abp-50.png	25 logo_50.png = icons/abp-50.png

20 logo_150.png = icons/abp-150.png	26 logo_150.png = icons/abp-150.png

OLD	NEW

« metadata.chrome ('K') | « metadata.chrome ('k') | qunit/tests/ioIndexedDB.js » ('j') | no next file with comments »