Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29798626: Fixes #91 - Homepage duplicate in Polish for SEM (Closed)

Created:
June 4, 2018, 3:06 p.m. by ire
Modified:
June 6, 2018, 5:36 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #91 - Homepage duplicate in Polish for SEM

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -40 lines) Patch
R includes/abb-cross-promotion.html View 1 chunk +0 lines, -38 lines 0 comments Download
A includes/abb-cross-promotion.tmpl View 1 chunk +38 lines, -0 lines 0 comments Download
M includes/as-mentioned.tmpl View 1 chunk +1 line, -1 line 0 comments Download
A locales/pl/img/apple-app-store-badge.png View Binary file 0 comments Download
A locales/pl/img/apple-app-store-badge.svg View 1 chunk +41 lines, -0 lines 0 comments Download
A locales/pl/img/google-play-badge.png View Binary file 0 comments Download
A locales/pl/poland.json View 1 chunk +79 lines, -0 lines 0 comments Download
A pages/poland.tmpl View 1 chunk +30 lines, -0 lines 0 comments Download
M static/css/index.css View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5
ire
June 4, 2018, 3:06 p.m. (2018-06-04 15:06:23 UTC) #1
ire
Ready for review. Question: the page is currently only accessible via /pl/poland . Is there ...
June 4, 2018, 3:08 p.m. (2018-06-04 15:08:07 UTC) #2
juliandoucette
On 2018/06/04 15:08:07, ire wrote: > Ready for review. > > Question: the page is ...
June 5, 2018, 9:01 p.m. (2018-06-05 21:01:55 UTC) #3
ire
On 2018/06/05 21:01:55, juliandoucette wrote: > On 2018/06/04 15:08:07, ire wrote: > > Ready for ...
June 6, 2018, 2:40 p.m. (2018-06-06 14:40:26 UTC) #4
ire
June 6, 2018, 3:32 p.m. (2018-06-06 15:32:41 UTC) #5
Looks like I have to scrap this :/

I'll start a new review

Powered by Google App Engine
This is Rietveld