Issue 6559 - Use Map object for known subscriptions

lib/filterListener.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 223 matching lines @@
   FilterListener.setDirty(1);
 
   if (!subscription.disabled)
     subscription.filters.forEach(removeFilter);
 }
 
 function onSubscriptionDisabled(subscription, newValue)
 {
   FilterListener.setDirty(1);
 
-  if (subscription.url in FilterStorage.knownSubscriptions)
+  if (FilterStorage.knownSubscriptions.has(subscription.url))
   {
     if (newValue == false)
       addFilters(subscription.filters);
     else
       subscription.filters.forEach(removeFilter);
   }
 }
 
 function onSubscriptionUpdated(subscription)
 {
   FilterListener.setDirty(1);
 
-  if (subscription.url in FilterStorage.knownSubscriptions &&
-      !subscription.disabled)
+  if (!subscription.disabled &&

[Manish Jethani, 2018/06/06 11:04:42]

Better to check if the subscription is disabled first so we avoid the lookup.

[kzar, 2018/06/07 13:52:26]

Acknowledged.

+      FilterStorage.knownSubscriptions.has(subscription.url))
   {
     subscription.oldFilters.forEach(removeFilter);
     addFilters(subscription.filters);
   }
 }
 
 function onFilterHitCount(filter, newValue)
 {
   if (newValue == 0)
     FilterListener.setDirty(0);
@@ skipping 48 matching lines @@
   {
     if (!subscription.disabled)
       addFilters(subscription.filters);
   }
 }
 
 function onSave()
 {
   isDirty = 0;
 }