Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code
Issues
All Issues

Issue 29800606: Fixes #91 - Homepage duplicate in Polish for SEM (Closed)

Created:
June 6, 2018, 5:37 p.m. by ire
Modified:
June 19, 2018, 3:11 p.m.
Reviewers:
juliandoucette
Base URL:
https://hg.adblockplus.org/web.adblockplus.org
Visibility:
Public.

Description

Fixes #91 - Homepage duplicate in Polish for SEM

Patch Set 1 #

Total comments: 12

Patch Set 2 : Addressed comments #3 #

Patch Set 3 : Updated content #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3276 lines, -0 lines) Patch
A static/poland.html View 1 2 1 chunk +314 lines, -0 lines 0 comments Download
A static/poland/css/defaults.css View 1 chunk +539 lines, -0 lines 0 comments Download
A static/poland/css/fonts.css View 1 chunk +255 lines, -0 lines 0 comments Download
A static/poland/css/index.css View 1 2 1 chunk +361 lines, -0 lines 0 comments Download
A static/poland/css/main.css View 1 2 1 chunk +877 lines, -0 lines 0 comments Download
A static/poland/img/abb-logo.png View Binary file 0 comments Download
A static/poland/img/apple-app-store-badge.png View Binary file 0 comments Download
A static/poland/img/apple-app-store-badge.svg View 1 chunk +41 lines, -0 lines 0 comments Download
A static/poland/img/external-icon.png View 1 Binary file 0 comments Download
A static/poland/img/external-icon.svg View 1 1 chunk +13 lines, -0 lines 0 comments Download
A static/poland/img/feature-aa.png View Binary file 0 comments Download
A static/poland/img/feature-aa.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/feature-fast.png View Binary file 0 comments Download
A static/poland/img/feature-fast.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/feature-safe.png View Binary file 0 comments Download
A static/poland/img/feature-safe.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/footer-facebook-glyphicon.png View Binary file 0 comments Download
A static/poland/img/footer-instagram-glyphicon.png View Binary file 0 comments Download
A static/poland/img/footer-twitter-glyphicon.png View Binary file 0 comments Download
A static/poland/img/footer-youtube-glyphicon.png View Binary file 0 comments Download
A static/poland/img/google-play-badge.png View Binary file 0 comments Download
A static/poland/img/hero-video.jpg View Binary file 0 comments Download
A static/poland/img/hero-video-2x.jpg View Binary file 0 comments Download
A static/poland/img/media/business-insider.png View Binary file 0 comments Download
A static/poland/img/media/business-insider-2x.png View Binary file 0 comments Download
A static/poland/img/media/mediapost.png View Binary file 0 comments Download
A static/poland/img/media/mediapost-2x.png View Binary file 0 comments Download
A static/poland/img/media/nyt.png View Binary file 0 comments Download
A static/poland/img/media/nyt-2x.png View Binary file 0 comments Download
A static/poland/img/media/techcrunch.png View Binary file 0 comments Download
A static/poland/img/media/techcrunch-2x.png View Binary file 0 comments Download
A static/poland/img/media/wsj.png View Binary file 0 comments Download
A static/poland/img/media/wsj-2x.png View Binary file 0 comments Download
A static/poland/img/menu-toggle.png View Binary file 0 comments Download
A static/poland/img/menu-toggle.svg View 1 1 chunk +43 lines, -0 lines 0 comments Download
A static/poland/img/navbar-logo.png View Binary file 0 comments Download
A static/poland/img/navbar-logo.svg View 1 chunk +1 line, -0 lines 0 comments Download
A static/poland/img/video-play.png View Binary file 0 comments Download
A static/poland/js/bowser.js View 1 chunk +601 lines, -0 lines 0 comments Download
A static/poland/js/index.js View 1 chunk +57 lines, -0 lines 0 comments Download
A static/poland/js/main.js View 1 chunk +171 lines, -0 lines 0 comments Download

Messages

Total messages: 7
ire
June 6, 2018, 5:37 p.m. (2018-06-06 17:37:44 UTC) #1
ire
Ready for review
June 6, 2018, 5:38 p.m. (2018-06-06 17:38:15 UTC) #2
juliandoucette
Thanks Ire! This is a lot to review thoroughly :-1: - but I think we've ...
June 8, 2018, 6:10 p.m. (2018-06-08 18:10:02 UTC) #3
juliandoucette
(also see comments in https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/91)
June 8, 2018, 6:16 p.m. (2018-06-08 18:16:44 UTC) #4
ire
Thanks! New patch up On 2018/06/08 18:16:44, juliandoucette wrote: > (also see comments in > ...
June 8, 2018, 6:28 p.m. (2018-06-08 18:28:41 UTC) #5
juliandoucette
On 2018/06/08 18:28:41, ire wrote: > Thanks! New patch up Thanks! Looks good! Still waiting ...
June 11, 2018, 4:11 p.m. (2018-06-11 16:11:02 UTC) #6
ire
June 14, 2018, 2:30 a.m. (2018-06-14 02:30:46 UTC) #7 
On 2018/06/11 16:11:02, juliandoucette wrote:
> On 2018/06/08 18:28:41, ire wrote:
> > Thanks! New patch up
> 
> Thanks! Looks good!
> 
> Still waiting on the navigation translations.

New patch set up! Still waiting on 2 things from Luiza
(https://gitlab.com/eyeo/websites/web.adblockplus.org/issues/91#note_81442897)
but otherwise we should be good

Powered by Google App Engine
This is Rietveld