Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: metadata.chrome

Issue 29801613: Issue 6321 - Move the popup under UI (Closed)
Left Patch Set: Created June 8, 2018, 1:12 p.m.
Right Patch Set: removed popup.png Created July 17, 2018, 4:22 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « icons/detailed/abp-64.png ('k') | popup.html » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 [general] 1 [general]
2 basename = adblockpluschrome 2 basename = adblockpluschrome
3 version = 3.1 3 version = 3.1
4 author = eyeo GmbH 4 author = eyeo GmbH
5 backgroundScripts = polyfill.js 5 backgroundScripts = polyfill.js
6 ext/common.js 6 ext/common.js
7 ext/background.js 7 ext/background.js
8 lib/compat.js 8 lib/compat.js
9 lib/publicSuffixList.js 9 lib/publicSuffixList.js
10 lib/adblockplus.js 10 lib/adblockplus.js
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 ext/content.js 55 ext/content.js
56 include.preload.js 56 include.preload.js
57 document_end = include.postload.js 57 document_end = include.postload.js
58 58
59 [mapping] 59 [mapping]
60 subscriptions.xml = adblockpluscore/chrome/content/ui/subscriptions.xml 60 subscriptions.xml = adblockpluscore/chrome/content/ui/subscriptions.xml
61 firstRun.html = adblockplusui/firstRun.html 61 firstRun.html = adblockplusui/firstRun.html
62 common.js = adblockplusui/common.js 62 common.js = adblockplusui/common.js
63 firstRun.js = adblockplusui/firstRun.js 63 firstRun.js = adblockplusui/firstRun.js
64 i18n.js = adblockplusui/i18n.js 64 i18n.js = adblockplusui/i18n.js
65 icons/detailed/abp-64.png = adblockplusui/skin/abp-64.png 65 icons/detailed/abp-64.png = adblockplusui/skin/abp-64.png
Thomas Greiner 2018/06/08 13:33:22 Detail: I don't see this file being removed from t
a.giammarchi 2018/06/08 13:44:22 Done.
66 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png 66 icons/detailed/abp-128.png = adblockplusui/skin/abp-128.png
67 skin/common.css = adblockplusui/skin/common.css 67 skin/common.css = adblockplusui/skin/common.css
68 skin/fonts.css = adblockplusui/skin/fonts.css 68 skin/fonts.css = adblockplusui/skin/fonts.css
69 skin/firstRun.css = adblockplusui/skin/firstRun.css 69 skin/firstRun.css = adblockplusui/skin/firstRun.css
70 skin/abp-logo.svg = adblockplusui/skin/abp-logo.svg 70 skin/abp-logo.svg = adblockplusui/skin/abp-logo.svg
71 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif 71 skin/ajax-loader.gif = adblockplusui/skin/ajax-loader.gif
72 skin/background.png = adblockplusui/skin/background.png 72 skin/background.png = adblockplusui/skin/background.png
73 skin/background-main.png = adblockplusui/skin/background-main.png 73 skin/background-main.png = adblockplusui/skin/background-main.png
74 skin/background-share.png = adblockplusui/skin/background-share.png 74 skin/background-share.png = adblockplusui/skin/background-share.png
75 skin/donate.png = adblockplusui/skin/donate.png 75 skin/donate.png = adblockplusui/skin/donate.png
76 skin/abb-logo.png = adblockplusui/skin/abb-logo.png 76 skin/abb-logo.png = adblockplusui/skin/abb-logo.png
77 skin/fonts/CreteRound-Italic.otf = adblockplusui/skin/fonts/CreteRound-Italic.ot f 77 skin/fonts/CreteRound-Italic.otf = adblockplusui/skin/fonts/CreteRound-Italic.ot f
78 skin/fonts/CreteRound-Regular.otf = adblockplusui/skin/fonts/CreteRound-Regular. otf 78 skin/fonts/CreteRound-Regular.otf = adblockplusui/skin/fonts/CreteRound-Regular. otf
79 skin/fonts/Source-Sans-Pro/LICENSE.txt = adblockplusui/skin/fonts/Source-Sans-Pr o/LICENSE.txt
80 skin/fonts/Source-Sans-Pro/300/cyrillic.woff2 = adblockplusui/skin/fonts/Source- Sans-Pro/300/cyrillic.woff2 79 skin/fonts/Source-Sans-Pro/300/cyrillic.woff2 = adblockplusui/skin/fonts/Source- Sans-Pro/300/cyrillic.woff2
81 skin/fonts/Source-Sans-Pro/300/cyrillic-ext.woff2 = adblockplusui/skin/fonts/Sou rce-Sans-Pro/300/cyrillic-ext.woff2 80 skin/fonts/Source-Sans-Pro/300/cyrillic-ext.woff2 = adblockplusui/skin/fonts/Sou rce-Sans-Pro/300/cyrillic-ext.woff2
82 skin/fonts/Source-Sans-Pro/300/greek.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/300/greek.woff2 81 skin/fonts/Source-Sans-Pro/300/greek.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/300/greek.woff2
83 skin/fonts/Source-Sans-Pro/300/greek-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/300/greek-ext.woff2 82 skin/fonts/Source-Sans-Pro/300/greek-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/300/greek-ext.woff2
84 skin/fonts/Source-Sans-Pro/300/latin.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/300/latin.woff2 83 skin/fonts/Source-Sans-Pro/300/latin.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/300/latin.woff2
85 skin/fonts/Source-Sans-Pro/300/latin-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/300/latin-ext.woff2 84 skin/fonts/Source-Sans-Pro/300/latin-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/300/latin-ext.woff2
86 skin/fonts/Source-Sans-Pro/300/vietnamese.woff2 = adblockplusui/skin/fonts/Sourc e-Sans-Pro/300/vietnamese.woff2 85 skin/fonts/Source-Sans-Pro/300/vietnamese.woff2 = adblockplusui/skin/fonts/Sourc e-Sans-Pro/300/vietnamese.woff2
87 skin/fonts/Source-Sans-Pro/400/cyrillic.woff2 = adblockplusui/skin/fonts/Source- Sans-Pro/400/cyrillic.woff2 86 skin/fonts/Source-Sans-Pro/400/cyrillic.woff2 = adblockplusui/skin/fonts/Source- Sans-Pro/400/cyrillic.woff2
88 skin/fonts/Source-Sans-Pro/400/cyrillic-ext.woff2 = adblockplusui/skin/fonts/Sou rce-Sans-Pro/400/cyrillic-ext.woff2 87 skin/fonts/Source-Sans-Pro/400/cyrillic-ext.woff2 = adblockplusui/skin/fonts/Sou rce-Sans-Pro/400/cyrillic-ext.woff2
89 skin/fonts/Source-Sans-Pro/400/greek.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/400/greek.woff2 88 skin/fonts/Source-Sans-Pro/400/greek.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/400/greek.woff2
90 skin/fonts/Source-Sans-Pro/400/greek-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/400/greek-ext.woff2 89 skin/fonts/Source-Sans-Pro/400/greek-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/400/greek-ext.woff2
91 skin/fonts/Source-Sans-Pro/400/latin.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/400/latin.woff2 90 skin/fonts/Source-Sans-Pro/400/latin.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/400/latin.woff2
92 skin/fonts/Source-Sans-Pro/400/latin-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/400/latin-ext.woff2 91 skin/fonts/Source-Sans-Pro/400/latin-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/400/latin-ext.woff2
93 skin/fonts/Source-Sans-Pro/400/vietnamese.woff2 = adblockplusui/skin/fonts/Sourc e-Sans-Pro/400/vietnamese.woff2 92 skin/fonts/Source-Sans-Pro/400/vietnamese.woff2 = adblockplusui/skin/fonts/Sourc e-Sans-Pro/400/vietnamese.woff2
94 skin/fonts/Source-Sans-Pro/700/cyrillic.woff2 = adblockplusui/skin/fonts/Source- Sans-Pro/700/cyrillic.woff2 93 skin/fonts/Source-Sans-Pro/700/cyrillic.woff2 = adblockplusui/skin/fonts/Source- Sans-Pro/700/cyrillic.woff2
95 skin/fonts/Source-Sans-Pro/700/cyrillic-ext.woff2 = adblockplusui/skin/fonts/Sou rce-Sans-Pro/700/cyrillic-ext.woff2 94 skin/fonts/Source-Sans-Pro/700/cyrillic-ext.woff2 = adblockplusui/skin/fonts/Sou rce-Sans-Pro/700/cyrillic-ext.woff2
96 skin/fonts/Source-Sans-Pro/700/greek.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/700/greek.woff2 95 skin/fonts/Source-Sans-Pro/700/greek.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/700/greek.woff2
97 skin/fonts/Source-Sans-Pro/700/greek-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/700/greek-ext.woff2 96 skin/fonts/Source-Sans-Pro/700/greek-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/700/greek-ext.woff2
98 skin/fonts/Source-Sans-Pro/700/latin.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/700/latin.woff2 97 skin/fonts/Source-Sans-Pro/700/latin.woff2 = adblockplusui/skin/fonts/Source-San s-Pro/700/latin.woff2
99 skin/fonts/Source-Sans-Pro/700/latin-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/700/latin-ext.woff2 98 skin/fonts/Source-Sans-Pro/700/latin-ext.woff2 = adblockplusui/skin/fonts/Source -Sans-Pro/700/latin-ext.woff2
100 skin/fonts/Source-Sans-Pro/700/vietnamese.woff2 = adblockplusui/skin/fonts/Sourc e-Sans-Pro/700/vietnamese.woff2 99 skin/fonts/Source-Sans-Pro/700/vietnamese.woff2 = adblockplusui/skin/fonts/Sourc e-Sans-Pro/700/vietnamese.woff2
100 skin/icons/android.svg = adblockplusui/skin/icons/android.svg
101 skin/icons/apple.svg = adblockplusui/skin/icons/apple.svg
101 skin/icons/attention.svg = adblockplusui/skin/icons/attention.svg 102 skin/icons/attention.svg = adblockplusui/skin/icons/attention.svg
103 skin/icons/block-element.svg = adblockplusui/skin/icons/block-element.svg
102 skin/icons/checkbox.png = adblockplusui/skin/icons/checkbox.png 104 skin/icons/checkbox.png = adblockplusui/skin/icons/checkbox.png
103 skin/icons/checkbox.svg = adblockplusui/skin/icons/checkbox.svg 105 skin/icons/checkbox.svg = adblockplusui/skin/icons/checkbox.svg
104 skin/icons/checkmark.svg = adblockplusui/skin/icons/checkmark.svg 106 skin/icons/checkmark.svg = adblockplusui/skin/icons/checkmark.svg
105 skin/icons/code.svg = adblockplusui/skin/icons/code.svg 107 skin/icons/code.svg = adblockplusui/skin/icons/code.svg
108 skin/icons/critical.svg = adblockplusui/skin/icons/critical.svg
106 skin/icons/delete.svg = adblockplusui/skin/icons/delete.svg 109 skin/icons/delete.svg = adblockplusui/skin/icons/delete.svg
110 skin/icons/info.svg = adblockplusui/skin/icons/info.svg
111 skin/icons/iconOn.svg = adblockplusui/skin/icons/iconOn.svg
112 skin/icons/iconOff.svg = adblockplusui/skin/icons/iconOff.svg
107 skin/icons/gear.svg = adblockplusui/skin/icons/gear.svg 113 skin/icons/gear.svg = adblockplusui/skin/icons/gear.svg
108 skin/icons/globe.svg = adblockplusui/skin/icons/globe.svg 114 skin/icons/globe.svg = adblockplusui/skin/icons/globe.svg
115 skin/icons/options.svg = adblockplusui/skin/icons/options.svg
109 skin/icons/reload.svg = adblockplusui/skin/icons/reload.svg 116 skin/icons/reload.svg = adblockplusui/skin/icons/reload.svg
117 skin/icons/report-issue.svg = adblockplusui/skin/icons/report-issue.svg
110 skin/icons/toggle.svg = adblockplusui/skin/icons/toggle.svg 118 skin/icons/toggle.svg = adblockplusui/skin/icons/toggle.svg
111 skin/icons/tooltip.svg = adblockplusui/skin/icons/tooltip.svg 119 skin/icons/tooltip.svg = adblockplusui/skin/icons/tooltip.svg
112 skin/icons/trash.svg = adblockplusui/skin/icons/trash.svg 120 skin/icons/trash.svg = adblockplusui/skin/icons/trash.svg
113 skin/social/facebook.png = adblockplusui/skin/social/facebook.png 121 skin/social/facebook.png = adblockplusui/skin/social/facebook.png
114 skin/social/facebook.svg = adblockplusui/skin/social/facebook.svg 122 skin/social/facebook.svg = adblockplusui/skin/social/facebook.svg
115 skin/social/googleplus.png = adblockplusui/skin/social/googleplus.png 123 skin/social/googleplus.png = adblockplusui/skin/social/googleplus.png
116 skin/social/googleplus.svg = adblockplusui/skin/social/googleplus.svg 124 skin/social/googleplus.svg = adblockplusui/skin/social/googleplus.svg
117 skin/social/renren.png = adblockplusui/skin/social/renren.png 125 skin/social/renren.png = adblockplusui/skin/social/renren.png
118 skin/social/twitter.png = adblockplusui/skin/social/twitter.png 126 skin/social/twitter.png = adblockplusui/skin/social/twitter.png
119 skin/social/twitter.svg = adblockplusui/skin/social/twitter.svg 127 skin/social/twitter.svg = adblockplusui/skin/social/twitter.svg
120 skin/social/weibo.png = adblockplusui/skin/social/weibo.png 128 skin/social/weibo.png = adblockplusui/skin/social/weibo.png
121 skin/updates/appstore-bg.svg = adblockplusui/skin/updates/appstore-bg.svg 129 skin/updates/appstore-bg.svg = adblockplusui/skin/updates/appstore-bg.svg
122 skin/updates/base-graphic.svg = adblockplusui/skin/updates/base-graphic.svg 130 skin/updates/base-graphic.svg = adblockplusui/skin/updates/base-graphic.svg
123 skin/updates/googleplay-bg.svg = adblockplusui/skin/updates/googleplay-bg.svg 131 skin/updates/googleplay-bg.svg = adblockplusui/skin/updates/googleplay-bg.svg
124 skin/updates/icon-mobile.svg = adblockplusui/skin/updates/icon-mobile.svg 132 skin/updates/icon-mobile.svg = adblockplusui/skin/updates/icon-mobile.svg
125 skin/updates/icon-rocket.svg = adblockplusui/skin/updates/icon-rocket.svg 133 skin/updates/icon-rocket.svg = adblockplusui/skin/updates/icon-rocket.svg
126 skin/updates/icon-thumbs-up.svg = adblockplusui/skin/updates/icon-thumbs-up.svg 134 skin/updates/icon-thumbs-up.svg = adblockplusui/skin/updates/icon-thumbs-up.svg
127 devtools-panel.html = adblockplusui/devtools-panel.html 135 devtools-panel.html = adblockplusui/devtools-panel.html
128 devtools-panel.js = adblockplusui/devtools-panel.js 136 devtools-panel.js = adblockplusui/devtools-panel.js
129 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css 137 skin/devtools-panel.css = adblockplusui/skin/devtools-panel.css
130 issue-reporter.html = adblockplusui/issue-reporter.html 138 issue-reporter.html = adblockplusui/issue-reporter.html
131 issue-reporter.js = adblockplusui/issue-reporter.js 139 issue-reporter.js = adblockplusui/issue-reporter.js
132 skin/issue-reporter.css = adblockplusui/skin/issue-reporter.css 140 skin/issue-reporter.css = adblockplusui/skin/issue-reporter.css
133 popup.html = adblockplusui/popup.html 141 popup.html = adblockplusui/popup.html
134 popup.js = adblockplusui/popup.js 142 popup.js = adblockplusui/popup.js
135 skin/popup.css = adblockplusui/skin/popup.css 143 skin/popup.css = adblockplusui/skin/popup.css
136 skin/popup.png = adblockplusui/skin/popup.png
137 desktop-options.html = adblockplusui/desktop-options.html 144 desktop-options.html = adblockplusui/desktop-options.html
138 desktop-options.js = adblockplusui/desktop-options.js 145 desktop-options.js = adblockplusui/desktop-options.js
139 skin/desktop-options.css = adblockplusui/skin/desktop-options.css 146 skin/desktop-options.css = adblockplusui/skin/desktop-options.css
140 updates.html = adblockplusui/updates.html 147 updates.html = adblockplusui/updates.html
141 updates.js = adblockplusui/updates.js 148 updates.js = adblockplusui/updates.js
142 skin/updates.css = adblockplusui/skin/updates.css 149 skin/updates.css = adblockplusui/skin/updates.css
150 LICENSE-3RD-PARTY.txt = adblockplusui/LICENSE-3RD-PARTY.txt
143 151
144 [bundles] 152 [bundles]
145 lib/adblockplus.js = 153 lib/adblockplus.js =
146 adblockpluscore/lib/filterListener.js 154 adblockpluscore/lib/filterListener.js
147 adblockpluscore/lib/synchronizer.js 155 adblockpluscore/lib/synchronizer.js
148 lib/devtools.js 156 lib/devtools.js
149 lib/requestBlocker.js 157 lib/requestBlocker.js
150 lib/popupBlocker.js 158 lib/popupBlocker.js
151 lib/subscriptionInit.js 159 lib/subscriptionInit.js
152 lib/filterComposer.js 160 lib/filterComposer.js
153 lib/stats.js 161 lib/stats.js
154 lib/uninstall.js 162 lib/uninstall.js
155 lib/csp.js 163 lib/csp.js
156 lib/cssInjection.js 164 lib/cssInjection.js
157 adblockplusui/messageResponder.js 165 adblockplusui/messageResponder.js
158 include.preload.js = 166 include.preload.js =
159 include.preload.js 167 include.preload.js
160 inject.preload.js 168 inject.preload.js
161 include.postload.js = 169 include.postload.js =
162 subscriptionLink.postload.js 170 subscriptionLink.postload.js
163 composer.postload.js 171 composer.postload.js
164 172
165 [import_locales] 173 [import_locales]
166 adblockplusui/locale/*/antiadblockInit.json = * 174 adblockplusui/locale/*/antiadblockInit.json = *
167 adblockplusui/locale/*/common.json = * 175 adblockplusui/locale/*/common.json = *
168 adblockplusui/locale/*/desktop-options.json = * 176 adblockplusui/locale/*/desktop-options.json = *
169 adblockplusui/locale/*/firstRun.json = * 177 adblockplusui/locale/*/firstRun.json = *
170 adblockplusui/locale/*/issue-reporter.json = * 178 adblockplusui/locale/*/issue-reporter.json = *
171 adblockplusui/locale/*/updates.json = * 179 adblockplusui/locale/*/updates.json = *
180 adblockplusui/locale/*/popup.json = *
LEFTRIGHT

Powered by Google App Engine
This is Rietveld