lib/filterStorage.js - Issue 29804571: Noissue - Remove unnecessary references to undefined

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: lib/filterStorage.js

Issue 29804571: Noissue - Remove unnecessary references to undefined (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Created June 12, 2018, 4:27 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: lib/filterStorage.js

===================================================================

--- a/lib/filterStorage.js

+++ b/lib/filterStorage.js

@@ -761,17 +761,17 @@

this.wantObj = true;

this.curObj = {};

break;

case "subscription filters":

this.wantObj = false;

this.curObj = [];

break;

default:

- this.wantObj = undefined;

Manish Jethani 2018/06/12 04:33:25 There's no reason to specifically assign this to u

+ this.wantObj = null;

this.curObj = null;

}

else if (this.wantObj === false && val)

this.curObj.push(val.replace(/\\\[/g, "["));

}

finally

{

« no previous file with comments | « no previous file | lib/synchronizer.js » ('j') | lib/synchronizer.js » ('J')