Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(178)

Issue 29805580: Issue 6728 - Remove Mercurial dependency (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 months ago by Jon Sonesen
Modified:
1 month ago
Reviewers:
Vasily Kuznetsov
CC:
Sebastian Noack, juliandoucette, rhowell, mathias
Visibility:
Public.

Description

Issue 6728 - Removes Mercurial dependency

Patch Set 1 #

Patch Set 2 : Addremove files to diff #

Total comments: 9

Patch Set 3 : Address PS2 comments #

Total comments: 5

Patch Set 4 : Address PS3 comments #

Patch Set 5 : Address PS4 comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -130 lines) Patch
M cms/sources.py View 1 2 3 chunks +6 lines, -57 lines 0 comments Download
M tests/conftest.py View 1 chunk +0 lines, -8 lines 0 comments Download
A tests/expected_output/en/rel_path@static View 1 1 chunk +3 lines, -0 lines 0 comments Download
R tests/expected_output/en/rel_path@static+master View 1 1 chunk +0 lines, -3 lines 0 comments Download
M tests/expected_output/en/sitemap View 1 chunk +0 lines, -1 line 0 comments Download
R tests/expected_output/en/sitemap@static+master View 1 1 chunk +0 lines, -30 lines 0 comments Download
M tests/test_additional_paths.py View 1 2 3 4 2 chunks +0 lines, -6 lines 0 comments Download
M tests/test_page_outputs.py View 1 2 3 2 chunks +10 lines, -25 lines 0 comments Download

Messages

Total messages: 12
Jon Sonesen
2 months ago (2018-06-12 22:33:39 UTC) #1
mathias
https://codereview.adblockplus.org/29805580/diff/29805586/cms/sources.py File cms/sources.py (right): https://codereview.adblockplus.org/29805580/diff/29805586/cms/sources.py#newcode238 cms/sources.py:238: return randint(1, 10) I think this should be a ...
2 months ago (2018-06-13 06:04:50 UTC) #2
Vasily Kuznetsov
Hi Jon, Looks pretty good, love the deleted code :D I'm thinking that perhaps we ...
2 months ago (2018-06-13 13:35:24 UTC) #3
Jon Sonesen
On 2018/06/13 13:35:24, Vasily Kuznetsov wrote: > Hi Jon, > > Looks pretty good, love ...
2 months ago (2018-06-14 19:24:07 UTC) #4
Jon Sonesen
https://codereview.adblockplus.org/29805580/diff/29805586/cms/sources.py File cms/sources.py (right): https://codereview.adblockplus.org/29805580/diff/29805586/cms/sources.py#newcode238 cms/sources.py:238: return randint(1, 10) On 2018/06/13 13:35:23, Vasily Kuznetsov wrote: ...
2 months ago (2018-06-14 19:24:15 UTC) #5
Vasily Kuznetsov
Hi Jon, Looks good, just some small adjustments. Cheers, Vasily https://codereview.adblockplus.org/29805580/diff/29805586/tests/conftest.py File tests/conftest.py (left): https://codereview.adblockplus.org/29805580/diff/29805586/tests/conftest.py#oldcode16 ...
1 month, 1 week ago (2018-07-03 08:50:24 UTC) #6
jsonesen
https://codereview.adblockplus.org/29805580/diff/29808569/tests/test_page_outputs.py File tests/test_page_outputs.py (right): https://codereview.adblockplus.org/29805580/diff/29808569/tests/test_page_outputs.py#newcode70 tests/test_page_outputs.py:70: source = FileSource(os.path.join('tests', 'test_site')) On 2018/07/03 08:50:24, Vasily Kuznetsov ...
1 month, 1 week ago (2018-07-05 18:58:32 UTC) #7
Vasily Kuznetsov
Hey Jon, All good, but how about we remove the ./tmp temporary directory from this ...
1 month, 1 week ago (2018-07-05 21:48:20 UTC) #8
Vasily Kuznetsov
Hi Jon, Two more comments before this can be pushed: - I found another place ...
1 month ago (2018-07-09 15:05:32 UTC) #9
Jon Sonesen
On 2018/07/09 15:05:32, Vasily Kuznetsov wrote: > Hi Jon, > > Two more comments before ...
1 month ago (2018-07-09 18:06:35 UTC) #10
Vasily Kuznetsov
LGTM. Although let's push it tomorrow carefully :D
1 month ago (2018-07-09 19:03:48 UTC) #11
Jon Sonesen
1 month ago (2018-07-09 19:24:37 UTC) #12
On 2018/07/09 19:03:48, Vasily Kuznetsov wrote:
> LGTM. Although let's push it tomorrow carefully :D

SGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5