Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29806570: Noissue - Add a test to confirm an evil rewrite gets cancelled (Closed)

Created:
June 13, 2018, 4:46 p.m. by hub
Modified:
June 13, 2018, 6:15 p.m.
Reviewers:
Manish Jethani, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Noissue - Add a test to confirm an evil rewrite gets cancelled

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M test/filterClasses.js View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3
hub
June 13, 2018, 4:46 p.m. (2018-06-13 16:46:26 UTC) #1
hub
I created this test to validate the we didn't just rewrite to anywhere, following the ...
June 13, 2018, 4:48 p.m. (2018-06-13 16:48:29 UTC) #2
Manish Jethani
June 13, 2018, 5:08 p.m. (2018-06-13 17:08:53 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld