Issue 6745 - Prefer strict equality operator

lib/matcher.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 50 matching lines @@
    * @param {RegExpFilter} filter
    */
   add(filter)
   {
     if (this.keywordByFilter.has(filter))
       return;
 
     // Look for a suitable keyword
     let keyword = this.findKeyword(filter);
     let oldEntry = this.filterByKeyword.get(keyword);
-    if (typeof oldEntry == "undefined")
+    if (typeof oldEntry === "undefined")
       this.filterByKeyword.set(keyword, filter);
-    else if (oldEntry.length == 1)
+    else if (oldEntry.length === 1)
       this.filterByKeyword.set(keyword, [oldEntry, filter]);
     else
       oldEntry.push(filter);
     this.keywordByFilter.set(filter, keyword);
   },
 
   /**
    * Removes a filter from the matcher
    * @param {RegExpFilter} filter
    */
   remove(filter)
   {
     let keyword = this.keywordByFilter.get(filter);
-    if (typeof keyword == "undefined")
+    if (typeof keyword === "undefined")
       return;
 
     let list = this.filterByKeyword.get(keyword);
     if (list.length <= 1)
       this.filterByKeyword.delete(keyword);
     else
     {
       let index = list.indexOf(filter);
       if (index >= 0)
       {
         list.splice(index, 1);
-        if (list.length == 1)
+        if (list.length === 1)
           this.filterByKeyword.set(keyword, list[0]);
       }
     }
 
     this.keywordByFilter.delete(filter);
   },
 
   /**
    * Chooses a keyword to be associated with the filter
    * @param {Filter} filter
    * @return {string} keyword or an empty string if no keyword could be found
    */
   findKeyword(filter)
   {
     let result = "";
     let {text} = filter;
     if (Filter.regexpRegExp.test(text))
       return result;
 
     // Remove options
     let match = Filter.optionsRegExp.exec(text);
     if (match)
       text = match.input.substr(0, match.index);
 
     // Remove whitelist marker
-    if (text[0] == "@" && text[1] == "@")
+    if (text[0] === "@" && text[1] === "@")
       text = text.substr(2);
 
     let candidates = text.toLowerCase().match(
       /[^a-z0-9%*][a-z0-9%]{3,}(?=[^a-z0-9%*])/g
     );
     if (!candidates)
       return result;
 
     let hash = this.filterByKeyword;
     let resultCount = 0xFFFFFF;
     let resultLength = 0;
     for (let i = 0, l = candidates.length; i < l; i++)
     {
       let candidate = candidates[i].substr(1);
       let filters = hash.get(candidate);
-      let count = typeof filters != "undefined" ? filters.length : 0;
+      let count = typeof filters !== "undefined" ? filters.length : 0;
       if (count < resultCount ||
-          (count == resultCount && candidate.length > resultLength))
+          (count === resultCount && candidate.length > resultLength))
       {
         result = candidate;
         resultCount = count;
         resultLength = candidate.length;
       }
     }
     return result;
   },
 
   /**
    * Checks whether a particular filter is being matched against.
    * @param {RegExpFilter} filter
    * @return {boolean}
    */
   hasFilter(filter)
   {
     return this.keywordByFilter.has(filter);
   },
 
   /**
    * Returns the keyword used for a filter, null for unknown filters.
    * @param {RegExpFilter} filter
    * @return {?string}
    */
   getKeywordForFilter(filter)
   {
     let keyword = this.keywordByFilter.get(filter);
-    return typeof keyword != "undefined" ? keyword : null;
+    return typeof keyword !== "undefined" ? keyword : null;
   },
 
   /**
    * Checks whether the entries for a particular keyword match a URL
    * @param {string} keyword
    * @param {string} location
    * @param {number} typeMask
    * @param {string} docDomain
    * @param {boolean} thirdParty
    * @param {string} sitekey
    * @param {boolean} specificOnly
    * @return {?Filter}
    */
   _checkEntryMatch(keyword, location, typeMask, docDomain, thirdParty, sitekey,
                    specificOnly)
   {
     let list = this.filterByKeyword.get(keyword);
-    if (typeof list == "undefined")
+    if (typeof list === "undefined")
       return null;
     for (let i = 0; i < list.length; i++)
     {
       let filter = list[i];
 
       if (specificOnly && filter.isGeneric() &&
           !(filter instanceof WhitelistFilter))
         continue;
 
       if (filter.matches(location, typeMask, docDomain, thirdParty, sitekey))
@@ skipping 205 matching lines @@
   /**
    * @see Matcher#matchesAny
    * @inheritdoc
    */
   matchesAny(location, typeMask, docDomain, thirdParty, sitekey, specificOnly)
   {
     let key = location + " " + typeMask + " " + docDomain + " " + thirdParty +
       " " + sitekey + " " + specificOnly;
 
     let result = this.resultCache.get(key);
-    if (typeof result != "undefined")
+    if (typeof result !== "undefined")
       return result;
 
     result = this.matchesAnyInternal(location, typeMask, docDomain,
                                      thirdParty, sitekey, specificOnly);
 
     if (this.resultCache.size >= CombinedMatcher.maxCacheEntries)
       this.resultCache.clear();
 
     this.resultCache.set(key, result);
 
     return result;
   }
 };
 
 /**
  * Shared CombinedMatcher instance that should usually be used.
  * @type {CombinedMatcher}
  */
 exports.defaultMatcher = new CombinedMatcher();