Issue 6745 - Prefer strict equality operator

lib/subscriptionClasses.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 53 matching lines @@
   /**
    * Title of the filter subscription
    * @type {string}
    */
   get title()
   {
     return this._title;
   },
   set title(value)
   {
-    if (value != this._title)
+    if (value !== this._title)
     {
       let oldValue = this._title;
       this._title = value;
       FilterNotifier.triggerListeners("subscription.title",
                                       this, value, oldValue);
     }
     return this._title;
   },
 
   /**
    * Determines whether the title should be editable
    * @type {boolean}
    */
   get fixedTitle()
   {
     return this._fixedTitle;
   },
   set fixedTitle(value)
   {
-    if (value != this._fixedTitle)
+    if (value !== this._fixedTitle)
     {
       let oldValue = this._fixedTitle;
       this._fixedTitle = value;
       FilterNotifier.triggerListeners("subscription.fixedTitle",
                                       this, value, oldValue);
     }
     return this._fixedTitle;
   },
 
   /**
    * Defines whether the filters in the subscription should be disabled
    * @type {boolean}
    */
   get disabled()
   {
     return this._disabled;
   },
   set disabled(value)
   {
-    if (value != this._disabled)
+    if (value !== this._disabled)
     {
       let oldValue = this._disabled;
       this._disabled = value;
       FilterNotifier.triggerListeners("subscription.disabled",
                                       this, value, oldValue);
     }
     return this._disabled;
   },
 
   /**
@@ skipping 39 matching lines @@
  *   URL of the subscription
  * @return {Subscription}
  *   subscription or null if the subscription couldn't be created
  */
 Subscription.fromURL = function(url)
 {
   let subscription = Subscription.knownSubscriptions.get(url);
   if (subscription)
     return subscription;
 
-  if (url[0] != "~")
+  if (url[0] !== "~")
     return new DownloadableSubscription(url, null);
   return new SpecialSubscription(url);
 };
 
 /**
  * Deserializes a subscription
  *
  * @param {Object}  obj
  *   map of serialized properties and their values
  * @return {Subscription}
  *   subscription or null if the subscription couldn't be created
  */
 Subscription.fromObject = function(obj)
 {
   let result;
-  if (obj.url[0] != "~")
+  if (obj.url[0] !== "~")
   {
     // URL is valid - this is a downloadable subscription
     result = new DownloadableSubscription(obj.url, obj.title);
     if ("downloadStatus" in obj)
       result._downloadStatus = obj.downloadStatus;
     if ("lastSuccess" in obj)
       result.lastSuccess = parseInt(obj.lastSuccess, 10) || 0;
     if ("lastCheck" in obj)
       result._lastCheck = parseInt(obj.lastCheck, 10) || 0;
     if ("expires" in obj)
@@ skipping 13 matching lines @@
     if ("downloadCount" in obj)
       result.downloadCount = parseInt(obj.downloadCount, 10) || 0;
   }
   else
   {
     result = new SpecialSubscription(obj.url, obj.title);
     if ("defaults" in obj)
       result.defaults = obj.defaults.split(" ");
   }
   if ("fixedTitle" in obj)
-    result._fixedTitle = (obj.fixedTitle == "true");
+    result._fixedTitle = (obj.fixedTitle === "true");
   if ("disabled" in obj)
-    result._disabled = (obj.disabled == "true");
+    result._disabled = (obj.disabled === "true");
 
   return result;
 };
 
 /**
  * Class for special filter subscriptions (user's filters)
  * @param {string} url see {@link Subscription Subscription()}
  * @param {string} [title]  see {@link Subscription Subscription()}
  * @constructor
  * @augments Subscription
@@ skipping 18 matching lines @@
    * @return {boolean}
    */
   isDefaultFor(filter)
   {
     if (this.defaults && this.defaults.length)
     {
       for (let type of this.defaults)
       {
         if (filter instanceof SpecialSubscription.defaultsMap.get(type))
           return true;
-        if (!(filter instanceof ActiveFilter) && type == "blacklist")
+        if (!(filter instanceof ActiveFilter) && type === "blacklist")
           return true;
       }
     }
 
     return false;
   },
 
   /**
    * See Subscription.serialize()
    * @inheritdoc
@@ skipping 76 matching lines @@
   /**
    * Filter subscription homepage if known
    * @type {string}
    */
   get homepage()
   {
     return this._homepage;
   },
   set homepage(value)
   {
-    if (value != this._homepage)
+    if (value !== this._homepage)
     {
       let oldValue = this._homepage;
       this._homepage = value;
       FilterNotifier.triggerListeners("subscription.homepage",
                                       this, value, oldValue);
     }
     return this._homepage;
   },
 
   /**
    * Time of the last subscription download (in seconds since the
    * beginning of the epoch)
    * @type {number}
    */
   get lastDownload()
   {
     return this._lastDownload;
   },
   set lastDownload(value)
   {
-    if (value != this._lastDownload)
+    if (value !== this._lastDownload)
     {
       let oldValue = this._lastDownload;
       this._lastDownload = value;
       FilterNotifier.triggerListeners("subscription.lastDownload",
                                       this, value, oldValue);
     }
     return this._lastDownload;
   },
 
   /**
@@ skipping 83 matching lines @@
    * to increase softExpiration if the user doesn't use Adblock Plus
    * for some time.
    * @type {number}
    */
   get lastCheck()
   {
     return this._lastCheck;
   },
   set lastCheck(value)
   {
-    if (value != this._lastCheck)
+    if (value !== this._lastCheck)
     {
       let oldValue = this._lastCheck;
       this._lastCheck = value;
       FilterNotifier.triggerListeners("subscription.lastCheck",
                                       this, value, oldValue);
     }
     return this._lastCheck;
   },
 
   /**
@@ skipping 13 matching lines @@
   /**
    * Number of download failures since last success
    * @type {number}
    */
   get errors()
   {
     return this._errors;
   },
   set errors(value)
   {
-    if (value != this._errors)
+    if (value !== this._errors)
     {
       let oldValue = this._errors;
       this._errors = value;
       FilterNotifier.triggerListeners("subscription.errors", this,
                                       value, oldValue);
     }
     return this._errors;
   },
 
   /**
@@ skipping 34 matching lines @@
     if (this.errors)
       buffer.push("errors=" + this.errors);
     if (this.version)
       buffer.push("version=" + this.version);
     if (this.requiredVersion)
       buffer.push("requiredVersion=" + this.requiredVersion);
     if (this.downloadCount)
       buffer.push("downloadCount=" + this.downloadCount);
   }
 });