Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(212)

Issue 29807589: Issue 6695 - Allow automatically downloading V8 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by hub
Modified:
1 year, 2 months ago
Reviewers:
sergei
Base URL:
https://hg.adblockplus.org/libadblockplus/
Visibility:
Public.

Description

Issue 6695 - Allow automatically downloading V8

Patch Set 1 #

Total comments: 8

Patch Set 2 : Changes in README. Renamed Makefile target. #

Patch Set 3 : prebuilt, not prebuild #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -1 line) Patch
M .gitignore View 1 chunk +1 line, -0 lines 0 comments Download
M .hgignore View 1 chunk +1 line, -0 lines 0 comments Download
M Makefile View 1 2 2 chunks +12 lines, -0 lines 0 comments Download
M README.md View 1 2 1 chunk +16 lines, -1 line 0 comments Download

Messages

Total messages: 6
hub
1 year, 2 months ago (2018-06-15 01:52:48 UTC) #1
hub
it needs to be manually invoked. Probably needs refinements to support multiple targets.
1 year, 2 months ago (2018-06-15 01:53:57 UTC) #2
sergei
Although I would like to rather have scripts which don't know about CI and CI ...
1 year, 2 months ago (2018-06-18 10:16:25 UTC) #3
hub
I can change this to not use the CI scripts, but rather to have the ...
1 year, 2 months ago (2018-06-18 12:51:10 UTC) #4
hub
update patch
1 year, 2 months ago (2018-06-18 13:40:11 UTC) #5
sergei
1 year, 2 months ago (2018-06-18 13:54:42 UTC) #6
LGTM.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5