Delta Between Two Patch Sets: README.md
Issue 29807589:
Issue 6695 - Allow automatically downloading V8 (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Left Patch Set:
Created June 15, 2018, 1:52 a.m.
Right Patch Set: prebuilt, not prebuild
Created June 18, 2018, 1:39 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« Makefile ('k')
|
no next file »
|
no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 libadblockplus | 1 libadblockplus |
| 2 ============== | 2 ============== |
| 3 | 3 |
| 4 A C++ library offering the core functionality of Adblock Plus. | 4 A C++ library offering the core functionality of Adblock Plus. |
| 5 | 5 |
| 6 Getting/updating the dependencies | 6 Getting/updating the dependencies |
| 7 --------------------------------- | 7 --------------------------------- |
| 8 | 8 |
| 9 libadblockplus has dependencies that aren't part of this repository. They are | 9 libadblockplus has dependencies that aren't part of this repository. They are |
| 10 retrieved and updated during the build process, but you can also manually update | 10 retrieved and updated during the build process, but you can also manually update |
| (...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 43 * g++ multilib | 43 * g++ multilib |
| 44 | 44 |
| 45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/). | 45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/). |
| 46 | 46 |
| 47 You also need Python 2.7 and ensure that `python.exe` is in your `PATH`. | 47 You also need Python 2.7 and ensure that `python.exe` is in your `PATH`. |
| 48 | 48 |
| 49 ### Unix | 49 ### Unix |
| 50 | 50 |
| 51 You need V8 prior to building. Two options: | 51 You need V8 prior to building. Two options: |
| 52 | 52 |
| 53 * Use the default prebuild by invoking the make target | 53 * Use the default prebuild V8 by invoking the make target |
|
sergei
2018/06/18 10:16:25
Can we rephrase it to
Use the default prebuilt V8
hub
2018/06/18 12:51:10
Done.
| |
| 54 `v8prebuild`. This will download and extract the prebuild V8 for your | 54 `get-prebuilt-v8`. This will download and extract the prebuilt V8 for |
| 55 setup. The default environment will be set by the Makefile at build | 55 your setup. The default environment will be set by the Makefile at |
| 56 tine. If you are cross compiling use the same options as below to | 56 build time. If you are cross compiling use the same options as below |
|
sergei
2018/06/18 10:16:25
typo: tine->time.
hub
2018/06/18 12:51:10
Done.
| |
| 57 invoke make. | 57 to invoke make. |
| 58 | |
| 59 If you switch target platform using the same source tree, you should | |
| 60 manually remove the `third_party/prebuilt-v8` directory and redownload | |
| 61 again with the right options. | |
| 58 | 62 |
|
sergei
2018/06/18 10:16:25
I think we should add that if one needs the prebui
hub
2018/06/18 12:51:10
Done.
| |
| 59 Or | 63 Or |
| 60 | 64 |
| 61 * Prepare V8 and set environment variables LIBV8_LIB_DIR and LIBV8_INCLUDE_DIR. | 65 * Prepare V8 and set environment variables LIBV8_LIB_DIR and LIBV8_INCLUDE_DIR. |
| 62 LIBV8_INCLUDE_DIR should point to the include directory of V8, e.g. | 66 LIBV8_INCLUDE_DIR should point to the include directory of V8, e.g. |
| 63 `.../v8/include` and there should be `libv8_monolith.a` in the directory | 67 `.../v8/include` and there should be `libv8_monolith.a` in the directory |
| 64 LIBV8_LIB_DIR. | 68 LIBV8_LIB_DIR. |
| 65 | 69 |
| 66 To build: | 70 To build: |
| 67 | 71 |
| 68 Using Make: | 72 Using Make: |
| (...skipping 225 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 294 Linting | 298 Linting |
| 295 ------- | 299 ------- |
| 296 | 300 |
| 297 You can lint the code using [ESLint](http://eslint.org). | 301 You can lint the code using [ESLint](http://eslint.org). |
| 298 | 302 |
| 299 npm run eslint | 303 npm run eslint |
| 300 | 304 |
| 301 In order to set up ESLint and | 305 In order to set up ESLint and |
| 302 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. | 306 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory. |
| 303 | 307 |
| LEFT | RIGHT |
« Makefile ('k')
|
no next file »
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
