README.md - Issue 29807589: Issue 6695 - Allow automatically downloading V8

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29807589: Issue 6695 - Allow automatically downloading V8 (Closed) Base URL: https://hg.adblockplus.org/libadblockplus/

Left Patch Set: Changes in README. Renamed Makefile target. Created June 18, 2018, 12:50 p.m.

Right Patch Set: prebuilt, not prebuild Created June 18, 2018, 1:39 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 libadblockplus	1 libadblockplus

2 ==============	2 ==============

3	3

4 A C++ library offering the core functionality of Adblock Plus.	4 A C++ library offering the core functionality of Adblock Plus.

5	5

6 Getting/updating the dependencies	6 Getting/updating the dependencies

7 ---------------------------------	7 ---------------------------------

8	8

9 libadblockplus has dependencies that aren't part of this repository. They are	9 libadblockplus has dependencies that aren't part of this repository. They are

10 retrieved and updated during the build process, but you can also manually update	10 retrieved and updated during the build process, but you can also manually update

(...skipping 33 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
44	44

45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/).	45 If you have a compilation issue with another compiler please [create an issue](h ttps://issues.adblockplus.org/).

46	46

47 You also need Python 2.7 and ensure that `python.exe` is in your `PATH`.	47 You also need Python 2.7 and ensure that `python.exe` is in your `PATH`.

48	48

49 ### Unix	49 ### Unix

50	50

51 You need V8 prior to building. Two options:	51 You need V8 prior to building. Two options:

52	52

53 * Use the default prebuild V8 by invoking the make target	53 * Use the default prebuild V8 by invoking the make target

54 `get-prebuild-v8`. This will download and extract the prebuild V8 for	54 `get-prebuilt-v8`. This will download and extract the prebuilt V8 for

55 your setup. The default environment will be set by the Makefile at	55 your setup. The default environment will be set by the Makefile at

56 build time. If you are cross compiling use the same options as below	56 build time. If you are cross compiling use the same options as below

57 to invoke make.	57 to invoke make.

58	58

59 If you switch target platform using the same source tree, you should	59 If you switch target platform using the same source tree, you should

60 manually remove the `third_party/prebuilt-v8` directory and redownload	60 manually remove the `third_party/prebuilt-v8` directory and redownload

61 again with the right options.	61 again with the right options.

62	62

63 Or	63 Or

64	64

(...skipping 233 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
298 Linting	298 Linting

299 -------	299 -------

300	300

301 You can lint the code using [ESLint](http://eslint.org).	301 You can lint the code using [ESLint](http://eslint.org).

302	302

303 npm run eslint	303 npm run eslint

304	304

305 In order to set up ESLint and	305 In order to set up ESLint and

306 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.	306 [configuration eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/t ip/eslint-config-eyeo) you need [Node.js 7 or higher](https://nodejs.org/) and o nce it is installed please run `npm install` in the repository directory.

307	307

LEFT	RIGHT