Unified Diff: README.md
Issue 29807589:
Issue 6695 - Allow automatically downloading V8 (Closed)
Base URL: https://hg.adblockplus.org/libadblockplus/
Patch Set:
Created June 15, 2018, 1:52 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« Makefile ('K')
|
« Makefile ('k')
|
no next file »
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: README.md |
| =================================================================== |
| --- a/README.md |
| +++ b/README.md |
| @@ -43,31 +43,42 @@ |
| * g++ multilib |
| If you have a compilation issue with another compiler please [create an issue](https://issues.adblockplus.org/). |
| You also need Python 2.7 and ensure that `python.exe` is in your `PATH`. |
| ### Unix |
| +You need V8 prior to building. Two options: |
| + |
| +* Use the default prebuild by invoking the make target |
|
sergei
2018/06/18 10:16:25
Can we rephrase it to
Use the default prebuilt V8
hub
2018/06/18 12:51:10
Done.
|
| +`v8prebuild`. This will download and extract the prebuild V8 for your |
| +setup. The default environment will be set by the Makefile at build |
| +tine. If you are cross compiling use the same options as below to |
|
sergei
2018/06/18 10:16:25
typo: tine->time.
hub
2018/06/18 12:51:10
Done.
|
| +invoke make. |
| + |
|
sergei
2018/06/18 10:16:25
I think we should add that if one needs the prebui
hub
2018/06/18 12:51:10
Done.
|
| +Or |
| + |
| * Prepare V8 and set environment variables LIBV8_LIB_DIR and LIBV8_INCLUDE_DIR. |
| LIBV8_INCLUDE_DIR should point to the include directory of V8, e.g. |
| `.../v8/include` and there should be `libv8_monolith.a` in the directory |
| LIBV8_LIB_DIR. |
| +To build: |
| + |
| Using Make: |
| make |
| The default target architecture is the architecture of a host. In order to build for a different architecture pass `TARGET_ARCH` to `make`, e.g. run: |
| make TARGET_ARCH=ia32 |
| supported values are `ia32` and `x64`. |
| - |
| To build and run the tests: |
| make test |
| Likewise, use the following with `TARGET_ARCH`: |
| make test TARGET_ARCH=ia32 |
