Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Keyboard Shortcuts
File
u
:
up to issue
m
:
publish + mail comments
M
:
edit review message
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
<Enter>
:
respond to / edit current comment
d
:
mark current comment as done
Issue
u
:
up to list of issues
m
:
publish + mail comments
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
#
:
close issue
Comment/message editing
<Ctrl>
+
s
or
<Ctrl>
+
Enter
:
save comment
<Esc>
:
cancel edit
Rietveld
Code Review Tool
Help
|
Bug tracker
|
Discussion group
|
Source code
Issues
All Issues
Side by Side Diff: .hgignore
Issue
29808587
:
Issue 6717 - Part 1: run eslint through npm (Closed)
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Patch Set: Use eslint5. Fix eslint error.
Created July 13, 2018, 3:04 p.m.
Left:
Base
Patch Set 1: None
Patch Set 2: Forgot the hgignore and gitignore
Patch Set 3: Use eslint4 and eyeo eslint 2.0.0. Rename task to "lint"
Patch Set 4: Use eslint5. Fix eslint error.
Patch Set 5: Require eslint-config-eyeo 2.1.0
Right:
Patch Set 1: None
Patch Set 2: Forgot the hgignore and gitignore
Patch Set 3: Use eslint4 and eyeo eslint 2.0.0. Rename task to "lint"
Patch Set 4: Use eslint5. Fix eslint error.
Patch Set 5: Require eslint-config-eyeo 2.1.0
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
.gitignore
.hgignore
README.md
ext/background.js
package.json
View unified diff
|
Download patch
« no previous file with comments
|
« .gitignore
('k') |
README.md »
('j') |
README.md »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 ^devenv.*$
1 ^devenv.*$
2
^node_modules$
2
3
3 syntax:glob
4 syntax:glob
4 *.zip
5 *.zip
5 *.crx
6 *.crx
6 *.xpi
7 *.xpi
7 *.pyc
8 *.pyc
8 *.pyo
9 *.pyo
9 *.sh
10 *.sh
OLD
NEW
« no previous file with comments
|
« .gitignore
('k') |
README.md »
('j') |
README.md »
('J')
Edit Message
Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed)
Created June 15, 2018, 8:13 p.m. by hub
Modified Aug. 14, 2018, 8:27 p.m.
Reviewers Sebastian Noack, kzar
Base URL: https://hg.adblockplus.org/adblockpluschrome/
Comments: 13
This is Rietveld