package.json - Issue 29808587: Issue 6717 - Part 1: run eslint through npm

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: package.json

Issue 29808587: Issue 6717 - Part 1: run eslint through npm (Closed) Base URL: https://hg.adblockplus.org/adblockpluschrome/

Left Patch Set: Forgot the hgignore and gitignore Created June 15, 2018, 8:17 p.m.

Right Patch Set: Require eslint-config-eyeo 2.1.0 Created Aug. 14, 2018, 11:36 a.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 {	1 {

2 "name": "adblockpluschrome",	2 "name": "adblockpluschrome",

3 "repository": "https://hg.adblockplus.org/adblockpluschrome",	3 "repository": "https://hg.adblockplus.org/adblockpluschrome",

4 "license": "GPL-3.0",	4 "license": "GPL-3.0",

5 "dependencies": {},	5 "dependencies": {},

6 "devDependencies": {	6 "devDependencies": {

7 "eslint": "^3.19.0",	7 "eslint": "^5.1.0",

8 "eslint-config-eyeo": "1.0.4"	8 "eslint-config-eyeo": "^2.1.0"

9 },	9 },

10 "scripts": {	10 "scripts": {

11 "eslint": "eslint *.js lib/ qunit/ ext/ chrome/",	11 "lint": "eslint *.js lib/ qunit/ ext/",
Sebastian Noack 2018/06/15 21:34:26 For reference, in adblockplusui they called the sc For reference, in adblockplusui they called the script just "lint". Perhaps, we might want to keep that consistent. hub 2018/06/17 23:06:08 But in adblockpluscore it is called eslint (which Show quoted text On 2018/06/15 21:34:26, Sebastian Noack wrote: > For reference, in adblockplusui they called the script just "lint". Perhaps, we > might want to keep that consistent. But in adblockpluscore it is called eslint (which is what I based it off). So either or needs to be fixed to be consistent. I don't care either way, but consistency. hub 2018/06/18 12:15:56 Even libadblockplus use `eslint` as the script nam Show quoted text On 2018/06/17 23:06:08, hub wrote: > On 2018/06/15 21:34:26, Sebastian Noack wrote: > > For reference, in adblockplusui they called the script just "lint". Perhaps, > we > > might want to keep that consistent. > > But in adblockpluscore it is called eslint (which is what I based it off). So > either or needs to be fixed to be consistent. I don't care either way, but > consistency. Even libadblockplus use `eslint` as the script name.
12 "posttest": "npm run eslint"	12 "posttest": "npm run lint"

13 }	13 }

14 }	14 }

LEFT	RIGHT